mirror of https://github.com/deepseek-ai/deepseek-harness synced 2026-08-15 21:04:50 +00:00

Files

creatixchu 23c4745560 fix(web): assert the wrap-width premise instead of reserving a gutter

Review flagged that "equal by construction" rested on an engine behaviour I
had not measured: `scrollbar-gutter: stable` only equalizes the layers if the
engine applies it to `overflow: hidden` the way it does to `overflow-y: auto`.
Measured it on the running app across the three engines Playwright ships,
and the property does not hold up.

  engine    .input / .backdrop / .mirror wrap width
  chromium  776 / 776 / 776   (768 / 768 / 768 with the declaration)
  firefox   776 / 776 / 776   (unchanged by it — overlay scrollbar)
  WebKit    768 / 776 / 776   (unchanged by it)

WebKit reserves for `overflow-y: auto` and not for `overflow: hidden`, so the
declaration left .input at 768 against 776 — exactly the gap it was meant to
close — on the one engine where that gap is observable at all, while costing
every chromium user 8px of text column unconditionally. Reverted: the
composer's metrics are now the same as before this PR.

The WebKit gap predates this change and is not closed here. It is recorded in
the Agent Note with the numbers, and the browser scenario asserts the equality
on the lane's engine so a regression into that state fails loudly. The mirror
is unaffected on WebKit for the drafts measured — the extents still agree — but
a draft whose wrapping turns on those 8px would clamp it.

The review's monotonicity concern resolves the same way: the declaration was
never worse than master, because WebKit already measured 768 against 776
without it. It simply was not better.

Also from this round: the wrap-width assertion now covers .mirror as well as
the two glyph layers — it is the height authority, so a mirror alone wrapping
wider would measure the box short and clip content below the 14-line cap with
every other assertion green. Plus `renderGeometry`'s missing `@param
trailingNewline`, and both e2e tsconfig lists restored to alphabetical order.

2026-07-31 13:13:50 +08:00

717 B

Raw Blame History

Composer draft scrolling (14-line cap, two text layers)

At the start of the draft

draft overflows the capped box: true
visible lines: 14
both layers share one scroll extent: true
all three layers wrap at one width: true
textarea scroll offset: 0px
glyph layer tracks it: true
first draft line is on screen: true
last draft line is on screen: false

Scrolled to the end of the draft

textarea moved: true
glyph layer tracks it: true
first draft line has scrolled out above: true
last draft line is on screen: true

Draft ending in a newline, scrolled to the end

both layers share one scroll extent: true
glyph layer tracks the caret: true
last draft line is on screen: true

717 B Raw Blame History

Composer draft scrolling (14-line cap, two text layers)

At the start of the draft

Scrolled to the end of the draft

Draft ending in a newline, scrolled to the end

717 B

Raw Blame History