mirror of
https://github.com/deepseek-ai/deepseek-harness
synced 2026-08-15 21:04:50 +00:00
Add a gated Known Limitations and Deferred Work section to every package README
Every packages/*/* README now carries a canonical '## Known Limitations and
Deferred Work' section: condensed, evidence-backed bullets for consumer-visible
gaps (unimplemented features, platform caveats, MVP cuts) and consciously
postponed work (TODO/FIXME/XXX markers, RFC deferrals still open). The ten
pre-existing ad-hoc variants ('What is NOT here (TODO)', 'Deferred',
'Limitations (MVP)', 'Known limitations (tracked TODOs)', ...) are normalized
into the canonical heading.
A new doc-sync gate, scripts/verify-readme-limitations.ts, enforces the shape:
exactly one limitations-like heading per package README, byte-equal to the
canonical h2, with at least one bullet; near-miss headings fail so variants
cannot creep back. Packages with genuinely nothing to declare (dsh-brand,
dsh-timeout, dsh-subagent-mock, dsh-app-boot) are whitelisted in the script and
must NOT carry the section; whitelist entries are validated against the scanned
package set so a rename fails loud.
Wired into the doc-sync chain (package.json) and the run-gates doc-sync leaf
set; the standing rule lands in packages/AGENTS.md and the adding-a-package
cookbook; decision record in
docs/rfc/implemented/process/2026-07-10-readme-known-limitations-gate.md
(RFC index regenerated).
Also fixes two stale '(deferred)' markers claiming dsh-compact-basic is
unimplemented (the dsh-compact seam README's package table and the seam's
module doc comment).
This commit is contained in:
@@ -273,6 +273,7 @@ function docSyncLeafGates(): Gate[] {
|
||||
pnpmScript('type-equivalence', 'verify-type-equiv', { label: 'type equivalence' }),
|
||||
pnpmScript('translation-pairing', 'verify-translation-pairing', { label: 'translation pairing' }),
|
||||
pnpmScript('doc-budgets', 'verify-doc-budgets', { label: 'doc budgets' }),
|
||||
pnpmScript('readme-limitations', 'verify-readme-limitations', { label: 'readme limitations' }),
|
||||
]
|
||||
}
|
||||
|
||||
|
||||
134
scripts/verify-readme-limitations.ts
Normal file
134
scripts/verify-readme-limitations.ts
Normal file
@@ -0,0 +1,134 @@
|
||||
/**
|
||||
* Doc-sync gate: every package README carries the standard
|
||||
* `## Known Limitations and Deferred Work` section — the per-package home for
|
||||
* consumer-visible gaps and consciously postponed work that the
|
||||
* [documentation standard](../docs/AGENTS.md) assigns to the package-README
|
||||
* tier. One canonical heading instead of per-package variants ("Limitations",
|
||||
* "What is NOT here", …) keeps the section greppable across the repo and makes
|
||||
* its absence a gate failure rather than an oversight.
|
||||
*
|
||||
* A package with genuinely nothing to declare is listed in NO_LIMITATIONS
|
||||
* below and must NOT carry the section — an empty section invites boilerplate,
|
||||
* and a whitelisted package that gains real limitations leaves the whitelist
|
||||
* in the same change. Whitelist entries are validated against the scanned
|
||||
* package set, so a rename or removal fails loud instead of silently
|
||||
* un-gating a README.
|
||||
*
|
||||
* Checks, per packages/<group>/<pkg>/README.md (fenced code excluded):
|
||||
* 1. Non-whitelisted: exactly one limitations-like heading, byte-equal to the
|
||||
* canonical h2, with at least one top-level `- ` bullet before the next
|
||||
* heading.
|
||||
* 2. Whitelisted: no limitations-like heading at all.
|
||||
* 3. Every whitelist entry names a scanned package.
|
||||
*
|
||||
* "Limitations-like" also matches near-miss headings at any level ("known
|
||||
* limitations", "deferred work", "what is not here", a heading starting with
|
||||
* "limitations"/"deferred") so a drifted heading cannot impersonate the
|
||||
* canonical section and a second competing section cannot coexist with it.
|
||||
*
|
||||
* Checker, not fixer: it reports and never rewrites.
|
||||
* Run: `tsx scripts/verify-readme-limitations.ts`.
|
||||
*/
|
||||
|
||||
import { globSync, readFileSync } from 'node:fs'
|
||||
import { resolve } from 'node:path'
|
||||
|
||||
const root = resolve(import.meta.dirname, '..')
|
||||
|
||||
/** The one canonical section heading, required verbatim as an h2. */
|
||||
const CANONICAL = '## Known Limitations and Deferred Work'
|
||||
|
||||
/**
|
||||
* Packages with genuinely no known limitations or deferred work (keyed by
|
||||
* package directory relative to the repo root). Their READMEs must NOT carry
|
||||
* the section; adding one moves the package off this list in the same change.
|
||||
*/
|
||||
const NO_LIMITATIONS: readonly string[] = [
|
||||
'packages/support/subagent-mock',
|
||||
'packages/ui/app-boot',
|
||||
'packages/util/brand',
|
||||
'packages/util/timeout',
|
||||
]
|
||||
|
||||
/** A heading that reads as a limitations section — canonical or drifted. */
|
||||
function isLimitationsLike(headingText: string): boolean {
|
||||
return (
|
||||
/known limitation/i.test(headingText)
|
||||
|| /deferred work/i.test(headingText)
|
||||
|| /what is not here/i.test(headingText)
|
||||
|| /^limitations?\b/i.test(headingText)
|
||||
|| /^deferred\b/i.test(headingText)
|
||||
)
|
||||
}
|
||||
|
||||
interface Line {
|
||||
index: number
|
||||
raw: string
|
||||
}
|
||||
|
||||
/** Split a README into prose lines (fenced code dropped), keeping 1-based line numbers. */
|
||||
function proseLines(text: string): Line[] {
|
||||
let inFence = false
|
||||
const kept: Line[] = []
|
||||
text.split('\n').forEach((raw, i) => {
|
||||
if (raw.startsWith('```')) {
|
||||
inFence = !inFence
|
||||
return
|
||||
}
|
||||
if (!inFence) kept.push({ index: i + 1, raw })
|
||||
})
|
||||
return kept
|
||||
}
|
||||
|
||||
const readmes = globSync('packages/*/*/README.md', { cwd: root }).sort()
|
||||
const scannedPackages = new Set(readmes.map(path => path.slice(0, -'/README.md'.length)))
|
||||
const failures: string[] = []
|
||||
|
||||
for (const entry of NO_LIMITATIONS) {
|
||||
if (!scannedPackages.has(entry)) {
|
||||
failures.push(`whitelist entry ${entry} does not name a scanned package — renamed or removed? update NO_LIMITATIONS in scripts/verify-readme-limitations.ts in the same change`)
|
||||
}
|
||||
}
|
||||
|
||||
for (const readme of readmes) {
|
||||
const pkg = readme.slice(0, -'/README.md'.length)
|
||||
const lines = proseLines(readFileSync(resolve(root, readme), 'utf8'))
|
||||
const headings = lines.filter(line => /^#{1,6} /.test(line.raw))
|
||||
const limitations = headings.filter(line => isLimitationsLike(line.raw.replace(/^#{1,6}\s+/, '')))
|
||||
|
||||
if (NO_LIMITATIONS.includes(pkg)) {
|
||||
for (const heading of limitations) {
|
||||
failures.push(`${readme}:${heading.index}: whitelisted as having no known limitations, but carries ${JSON.stringify(heading.raw)} — drop the section or remove the package from NO_LIMITATIONS`)
|
||||
}
|
||||
continue
|
||||
}
|
||||
|
||||
const heading = limitations.at(0)
|
||||
if (heading === undefined) {
|
||||
failures.push(`${readme}: missing the \`${CANONICAL}\` section (a package with genuinely nothing to declare joins NO_LIMITATIONS in scripts/verify-readme-limitations.ts instead)`)
|
||||
continue
|
||||
}
|
||||
if (limitations.length > 1) {
|
||||
failures.push(`${readme}: ${limitations.length} limitations-like headings (lines ${limitations.map(line => line.index).join(', ')}) — keep exactly one \`${CANONICAL}\` section`)
|
||||
continue
|
||||
}
|
||||
if (heading.raw.trimEnd() !== CANONICAL) {
|
||||
failures.push(`${readme}:${heading.index}: non-canonical heading ${JSON.stringify(heading.raw)} — use \`${CANONICAL}\``)
|
||||
continue
|
||||
}
|
||||
const headingAt = lines.indexOf(heading)
|
||||
const body = lines.slice(headingAt + 1)
|
||||
const end = body.findIndex(line => /^#{1,6} /.test(line.raw))
|
||||
const section = end === -1 ? body : body.slice(0, end)
|
||||
if (!section.some(line => /^- /.test(line.raw))) {
|
||||
failures.push(`${readme}:${heading.index}: the \`${CANONICAL}\` section has no top-level \`- \` bullet — state the limitations, or whitelist the package if there are genuinely none`)
|
||||
}
|
||||
}
|
||||
|
||||
if (failures.length > 0) {
|
||||
console.error('verify-readme-limitations: violations found:')
|
||||
for (const failure of failures) console.error(` ${failure}`)
|
||||
process.exit(1)
|
||||
}
|
||||
|
||||
console.log(`verify-readme-limitations: ${readmes.length} package READMEs checked (${NO_LIMITATIONS.length} whitelisted), all conform.`)
|
||||
Reference in New Issue
Block a user