From 05adf5da4abffd573e8f4b771168844a8e9642ae Mon Sep 17 00:00:00 2001 From: Tianyi Cui <53024+tianyicui@users.noreply.github.com> Date: Sun, 26 Jul 2026 23:47:56 +0800 Subject: [PATCH] docs: reject the timers/promises sleep proposal after implementation PR #679 implemented the swap and falsified the note's parity premise: vitest's fake clock does not intercept node:timers/promises, so the change traded deterministic fast tests (llm-retry ~4s->~10s real sleeps, two pty teardown tests rewritten real-time, a weakened workflow grace-timer guard) for ~10 deleted lines. Moved the note proposed -> rejected with the verdict on the Status line; the frozen proposal body is kept per the rejected-lifecycle contract. --- ...26-builtin-timer-promises-for-hand-rolled-sleeps.i18n.yaml | 4 ++-- ...026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md | 2 +- ...-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) rename .agents/notes/{proposed => rejected}/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.i18n.yaml (71%) rename .agents/notes/{proposed => rejected}/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md (92%) rename .agents/notes/{proposed => rejected}/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md (93%) diff --git a/.agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.i18n.yaml b/.agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.i18n.yaml similarity index 71% rename from .agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.i18n.yaml rename to .agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.i18n.yaml index 95e1524788..c13545596e 100644 --- a/.agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.i18n.yaml +++ b/.agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.i18n.yaml @@ -2,5 +2,5 @@ # side as of the last confirmed-consistent state. Both languages carry equal authority; # after editing either side, bring the other along and re-record with: # pnpm run verify-translation-pairing --write -2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md: 1a012aeabc7f9445127d6b8edcbe2f72e62f0eba -2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md: 742d2c5ee8573c9b2bdf555c938c83dd6ea9f999 +2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md: 475fd632cd4f75c966d4693e049edd48a1301992 +2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md: 47b20fdb237ab52aecba6b7df20dbd25eeb1649e diff --git a/.agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md b/.agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md similarity index 92% rename from .agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md rename to .agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md index 1a012aeabc..475fd632cd 100644 --- a/.agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md +++ b/.agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md @@ -1,6 +1,6 @@ # Agent Note: Use node:timers/promises for hand-rolled cancellable sleeps -Status: proposed +Status: rejected — implementation (PR #679) falsified the parity premise: vitest's fake clock does not intercept `node:timers/promises`, so the swap costs deterministic fast tests for ~10 deleted lines English | [中文](2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md) diff --git a/.agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md b/.agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md similarity index 93% rename from .agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md rename to .agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md index 742d2c5ee8..47b20fdb23 100644 --- a/.agents/notes/proposed/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md +++ b/.agents/notes/rejected/simplification/2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.zh.md @@ -1,6 +1,6 @@ # Agent Note: 用 node:timers/promises 替代手写的可取消休眠 -Status: proposed +Status: rejected — 实现(PR #679)证伪了行为等价前提:vitest 的假时钟不拦截 `node:timers/promises`,这次替换用确定性的快速测试换来约 10 行删除,得不偿失 [English](2026-07-26-builtin-timer-promises-for-hand-rolled-sleeps.md) | 中文