Merge pull request #2346 from deepseek-harness/fix/web-max-tokens-turn-end-notice

fix(web): surface max-tokens turn ends as a localized truncation notice
This commit is contained in:
CreatixChu
2026-08-12 20:07:35 +08:00
committed by GitHub
24 changed files with 377 additions and 19 deletions

View File

@@ -1,7 +1,7 @@
// @vitest-environment jsdom
// Multimodal image surfaces over the BUILT client graph (the code-mode-fixture
// idiom: real bundles via AppWebEntry, keyless FixtureApiClient transport).
// Opens the fixture history session whose turn 72 carries an image in BOTH a
// Opens the fixture history session whose turn 73 carries an image in BOTH a
// user message and an assistant message, and pins the product surfaces: the
// history ImageGallery loading real fixture bytes through the authorized
// sessions.attachment route, the single-click ImageLightbox, and the composer

View File

@@ -0,0 +1,56 @@
// @vitest-environment jsdom
// Assembled max-tokens snapshot: boots the real built `packages/client/*/lib/
// client.js` bundles through AppWebEntry's ModuleLoader path against the
// keyless FixtureApiClient transport, opens the fixture session, and pins the
// surface its max-tokens turn (72) reaches — the turn-end notice row that a
// provider output-cap truncation must render instead of ending silently.
//
// The dot state is pinned beside the copy on purpose: `dot=warning` is what
// distinguishes this notice from the error row, so a regression that routes
// max-tokens through the turn-error presentation changes this file even when
// its own copy still renders.
import { mkdirSync, writeFileSync } from 'node:fs'
import { dirname, join } from 'node:path'
import { fireEvent, screen, waitFor, within } from '@testing-library/react'
import { describe, expect, it } from 'vitest'
import { hasClass, installAssembledBootEnv, mountAssembledApp, REFRESHING_GOLDEN } from './assembled-boot.ts'
const EXPECTED = join(process.cwd(), 'apps/web/tests/snapshots/max-tokens-notice/history-turn.expected.txt')
installAssembledBootEnv()
/** Normalize the notice row to stable fields: its dot state, title, and hint. */
function noticeShape(row: Element): string {
const first = (name: string): string =>
[...row.querySelectorAll('*')].filter(el => hasClass(el, name))[0]?.textContent?.trim() ?? '<absent>'
return [
`dot=${row.querySelector('[data-state]')?.getAttribute('data-state') ?? '<absent>'}`,
`title=${first('maxTokensTitle')}`,
`hint=${first('turnErrorMessage')}`,
].join('\n')
}
describe('assembled max-tokens turn-end notice', () => {
it('renders the localized truncation notice after the cut-off answer instead of ending silently', async () => {
mountAssembledApp()
const tree = await screen.findByRole('tree', { name: 'Sessions' }, { timeout: 10_000 })
fireEvent.click(await within(tree).findByText('Fixture 历史会话'))
// The truncated answer itself stays in the flow: the notice supplements the
// partial output, it never replaces it.
await screen.findByText(/条目 3这一条写到一半被/, undefined, { timeout: 10_000 })
const row = await waitFor(() => {
const found = [...document.querySelectorAll('[role="status"]')]
.find(candidate => [...candidate.querySelectorAll('*')].some(el => hasClass(el, 'maxTokensTitle')))
expect(found).not.toBeUndefined()
return found!
}, { timeout: 10_000 })
const shape = noticeShape(row)
if (REFRESHING_GOLDEN) {
mkdirSync(dirname(EXPECTED), { recursive: true })
writeFileSync(EXPECTED, shape)
}
await expect(shape).toMatchFileSnapshot(EXPECTED)
})
})

View File

@@ -0,0 +1,3 @@
dot=warning
title=Output token limit reached
hint=The reply was cut off; earlier output is preserved in the conversation. Send "continue" to let the model resume.

View File

@@ -2,7 +2,7 @@
// Assembled todo snapshot: boots the real built `packages/client/*/lib/
// client.js` bundles through AppWebEntry's ModuleLoader path against the
// keyless FixtureApiClient transport, opens the fixture session, and pins the
// two surfaces the fixture's parallel plan (turn 73, two items `in_progress`)
// two surfaces the fixture's parallel plan (turn 74, two items `in_progress`)
// reaches — the `todo_write` tool row and the dock's plan strip.
//
// The row is pinned as three separate fields on purpose. `summary=` is the