diff --git a/packages/client/ui-conversation/src/client/toolviews/search-row.module.css b/packages/client/ui-conversation/src/client/toolviews/search-row.module.css index 5c4eb1f7db..dd0395ec1d 100644 --- a/packages/client/ui-conversation/src/client/toolviews/search-row.module.css +++ b/packages/client/ui-conversation/src/client/toolviews/search-row.module.css @@ -93,3 +93,14 @@ clip: rect(0 0 0 0); white-space: nowrap; } + +/* The result text for an errored search, indented to the card's own column and + in the error tone, standing in for the search card the failure path does not + produce. */ +.failure { + margin: 4px 0 4px 22px; + white-space: pre-wrap; + overflow-wrap: anywhere; + font: var(--dsw-font-xs-13); + color: var(--dsw-alias-state-error-primary); +} diff --git a/packages/client/ui-conversation/src/client/toolviews/search-row.tsx b/packages/client/ui-conversation/src/client/toolviews/search-row.tsx index 90ec5e3470..0726f30a3c 100644 --- a/packages/client/ui-conversation/src/client/toolviews/search-row.tsx +++ b/packages/client/ui-conversation/src/client/toolviews/search-row.tsx @@ -40,6 +40,27 @@ function stateStatus(state: ToolRowState): string | null { } } +/** + * A settled result's text, flattened from its content blocks, for the arm that + * shows a failure the search card cannot: grep/glob have no `presentResult` on + * an error result, so an errored search has no card, and the keyed row is not a + * details-panel target. Without this the failure โ a bad pattern, a missing + * path, a nested run_code dispatch that returned no card โ would read as a bare + * red dot with the model-facing error text nowhere on screen. + * @param block - the frozen call slice. + * @returns the result text, or null for a running call or an empty result. + */ +function errorText(block: ToolRowProps['block']): string | null { + if (!('kind' in block)) return null + const parts: string[] = [] + for (const item of block.content) { + if (item.type === 'text') parts.push(item.text) + } + if (parts.length === 0 && block.error !== undefined) parts.push(`${block.error.name}: ${block.error.code}`) + const text = parts.join('\n') + return text === '' ? null : text +} + /** * Search row: icon + Search ยท {summary} in the shared ToolRow chrome, with the * completed search's card resident below it. The summary row is not a @@ -51,6 +72,9 @@ export function SearchRow({ toolName, block }: ToolRowProps) { const model = toolRowModel(toolName, block) const search = searchCardModel(block) const status = stateStatus(model.state) + // An errored search has no card (grep/glob return no presentResult on error); + // surface its result text so the failure is more than a red dot. + const failure = search === null && model.state === 'error' ? errorText(block) : null return (