From 63ad5d6d9810961eef240ccba2ea093b190b557a Mon Sep 17 00:00:00 2001
From: Huanqi Cao <caohuanqi@deepseek.com>
Date: Sun, 9 Aug 2026 18:53:38 +0800
Subject: [PATCH] refactor(cli): drop the redundant existence pre-check in
 resolveWindowsShellLayer
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

loadOverlayPatches already throws on a missing file (the caller named
it, so absence is a misconfiguration) — the existsSync guard was a
second fail-loud mechanism for the same miss with a prettier message.
The loader's throw keeps the fail-loud contract the Windows-default
note records.
---
 apps/cli/src/windows-shell.ts        | 9 +++------
 apps/cli/tests/windows-shell.spec.ts | 4 +++-
 2 files changed, 6 insertions(+), 7 deletions(-)

diff --git a/apps/cli/src/windows-shell.ts b/apps/cli/src/windows-shell.ts
index 425699ef4f..c36dc0519c 100644
--- a/apps/cli/src/windows-shell.ts
+++ b/apps/cli/src/windows-shell.ts
@@ -10,7 +10,6 @@
  * @module @deepseek-ai/dsh/windows-shell
  */
 
-import { existsSync } from 'node:fs'
 import { join } from 'node:path'
 import type { PatchOptions } from '@cordisjs/plugin-include'
 import { loadOverlayPatches, type ProfileLayer } from '@deepseek-ai/dsh-app-boot'
@@ -36,8 +35,9 @@ export interface WindowsShellLayer {
  * @param binName - the diagnostic prefix on thrown errors (`dsh`).
  * @returns the pwsh layer on win32, else `undefined`. A custom profile that
  *   mounts no base bundle is skipped (it owns its shell stack); a base
- *   bundle that ships no Windows shell patch fails loud — the shipped
- *   package always carries it, so a miss is a broken installation.
+ *   bundle whose Windows shell patch is missing fails loud in
+ *   {@link loadOverlayPatches} — the shipped package always carries it, so
+ *   a miss is a broken installation.
  */
 export function resolveWindowsShellLayer(
   platform: NodeJS.Platform,
@@ -48,8 +48,5 @@ export function resolveWindowsShellLayer(
   const base = layers.find(layer => layer.packageName === BASE_BUNDLE)
   if (base === undefined) return undefined
   const label = join(base.packageDir, WINDOWS_SHELL_PATCH_FILENAME)
-  if (!existsSync(label)) {
-    throw new Error(`${binName}: ${BASE_BUNDLE} ships no ${WINDOWS_SHELL_PATCH_FILENAME}`)
-  }
   return { label, patches: loadOverlayPatches(binName, label) }
 }
diff --git a/apps/cli/tests/windows-shell.spec.ts b/apps/cli/tests/windows-shell.spec.ts
index 80ba40cc34..fc562b7008 100644
--- a/apps/cli/tests/windows-shell.spec.ts
+++ b/apps/cli/tests/windows-shell.spec.ts
@@ -60,8 +60,10 @@ describe('resolveWindowsShellLayer', () => {
   it('fails loud when the base bundle ships no Windows shell patch', () => {
     const base = tempBase()
     mkdirSync(base, { recursive: true })
+    // The overlay loader owns the fail-loud contract: the caller named this
+    // file, so its absence is a misconfiguration, not "no overlay".
     expect(() => resolveWindowsShellLayer('win32', [fakeLayer(BASE_BUNDLE, base)], 'dsh'))
-      .toThrow(/@deepseek-ai\/dsh-base ships no windows\.cordis\.patch\.yml/)
+      .toThrow(/dsh: failed to read overlay .*windows\.cordis\.patch\.yml/)
   })
 })