feat: rename experimental-meta/-upgrade to meta/upgrade behind --experimental gate

apps/cli/tests/args.spec.ts

@@ -1,18 +1,18 @@
 import { afterEach, describe, expect, it, vi } from 'vitest'
 import { parseDshArgs } from '../src/args.ts'
 
-const parse = (argv: string[]) => parseDshArgs(argv, '1.2.3')
+const parse = (argv: string[], experimentalEnv = false) => parseDshArgs(argv, '1.2.3', experimentalEnv)
 
 /**
  * `parseDshArgs` calls `process.exit` for `--help`/`--version`/errors and lets
  * Commander print to the real streams; capture the exit code and mute output.
  */
-function exitCode(argv: string[]): number {
+function exitCode(argv: string[], experimentalEnv = false): number {
   const exit = vi.spyOn(process, 'exit').mockImplementation(() => { throw new Error('exit') })
   vi.spyOn(process.stdout, 'write').mockReturnValue(true)
   vi.spyOn(process.stderr, 'write').mockReturnValue(true)
   try {
-    parse(argv)
+    parse(argv, experimentalEnv)
     throw new Error(`expected ${JSON.stringify(argv)} to exit`)
   } catch {
     return exit.mock.calls.at(-1)?.[0] as number
@@ -30,7 +30,9 @@ describe('parseDshArgs', () => {
     expect(parse(['--config-replace', 'tree.yml'])).toEqual({ mode: 'tui', configReplace: 'tree.yml' })
     expect(parse(['--resume', 'sess', '--config', 'app.yml'])).toEqual({ mode: 'tui', config: 'app.yml', resume: 'sess' })
     expect(parse(['-p', 'do the thing'])).toEqual({ mode: 'headless', prompt: 'do the thing' })
-    expect(parse(['experimental-meta'])).toEqual({ mode: 'meta' })
+    // Experimental subcommands run under the per-invocation flag or the env opt-in.
+    expect(parse(['meta', '--experimental'])).toEqual({ mode: 'meta' })
+    expect(parse(['meta'], true)).toEqual({ mode: 'meta' })
     // Bare `web` carries no host/port: the shipped Web overlay owns the default.
     expect(parse(['web'])).toEqual({ mode: 'web', dev: false })
     expect(parse(['web', '--config', 'web.yml'])).toEqual({ mode: 'web', dev: false, config: 'web.yml' })
@@ -39,7 +41,8 @@ describe('parseDshArgs', () => {
     expect(parse(['web', '--host', '0.0.0.0', '--port', '8080', '--dev', '--workspace-root', '/w']))
       .toEqual({ mode: 'web', host: '0.0.0.0', port: 8080, dev: true, workspaceRoot: '/w' })
     // Guided fresh-session entries carry nothing: bare mode discriminant only.
-    expect(parse(['experimental-upgrade'])).toEqual({ mode: 'upgrade' })
+    expect(parse(['upgrade', '--experimental'])).toEqual({ mode: 'upgrade' })
+    expect(parse(['upgrade'], true)).toEqual({ mode: 'upgrade' })
     // --trusted-host is variadic and repeatable; authorities pass through unvalidated.
     expect(parse(['web', '--trusted-host', 'harness.internal:3080', 'lab.internal', '--trusted-host', '10.0.0.9']))
       .toEqual({ mode: 'web', dev: false, trustedHosts: ['harness.internal:3080', 'lab.internal', '10.0.0.9'] })
@@ -64,8 +67,8 @@ describe('parseDshArgs', () => {
     expect(exitCode(['web', '--dump-config', '--dump-default-config'])).toBe(1)
     expect(exitCode(['web', '--dump-default-config', '--config', 'w.yml'])).toBe(1)
     // A leaked dump flag on a subcommand that has none is a mistyped invocation.
-    expect(exitCode(['experimental-meta', '--dump-config'])).toBe(1)
-    expect(exitCode(['experimental-upgrade', '--dump-config'])).toBe(1)
+    expect(exitCode(['meta', '--experimental', '--dump-config'])).toBe(1)
+    expect(exitCode(['upgrade', '--experimental', '--dump-config'])).toBe(1)
   })
 
   it('exits nonzero instead of silently starting fresh or dropping inputs', () => {
@@ -88,20 +91,32 @@ describe('parseDshArgs', () => {
     expect(exitCode(['--config-replace', 'tree.yml', 'web'])).toBe(1)
     // Same rule for each subcommand that shares no option with the default
     // surface, so a leaked flag is a typo, not something to ignore.
-    // `experimental-meta` fixes its own config tree and always starts fresh,
+    // `meta` fixes its own config tree and always starts fresh,
     // so every default-surface option is rejected.
-    expect(exitCode(['experimental-meta', '--resume', 's'])).toBe(1)
-    expect(exitCode(['experimental-meta', '--config', 'c.yml'])).toBe(1)
-    expect(exitCode(['experimental-meta', '--config-replace', 'tree.yml'])).toBe(1)
-    expect(exitCode(['experimental-meta', '-p', 'task'])).toBe(1)
-    // `experimental-upgrade` takes no options: any leaked default-surface flag
-    // is a mistyped invocation, not a silently-dropped input.
-    expect(exitCode(['experimental-upgrade', '--resume', 's'])).toBe(1)
-    expect(exitCode(['experimental-upgrade', '--config', 'c.yml'])).toBe(1)
-    expect(exitCode(['-p', 'task', 'experimental-upgrade'])).toBe(1)
+    expect(exitCode(['meta', '--experimental', '--resume', 's'])).toBe(1)
+    expect(exitCode(['meta', '--experimental', '--config', 'c.yml'])).toBe(1)
+    expect(exitCode(['meta', '--experimental', '--config-replace', 'tree.yml'])).toBe(1)
+    expect(exitCode(['meta', '--experimental', '-p', 'task'])).toBe(1)
+    // `upgrade` takes no options beyond the gate: any leaked default-surface
+    // flag is a mistyped invocation, not a silently-dropped input.
+    expect(exitCode(['upgrade', '--experimental', '--resume', 's'])).toBe(1)
+    expect(exitCode(['upgrade', '--experimental', '--config', 'c.yml'])).toBe(1)
+    expect(exitCode(['-p', 'task', 'upgrade', '--experimental'])).toBe(1)
     // The pre-release command names have no compatibility aliases.
+    expect(exitCode(['experimental-meta'])).toBe(1)
+    expect(exitCode(['experimental-upgrade'])).toBe(1)
+  })
+
+  it('gates experimental subcommands behind --experimental or the env opt-in', () => {
+    // Bare `meta`/`upgrade` without either opt-in must fail loud, not run.
     expect(exitCode(['meta'])).toBe(1)
     expect(exitCode(['upgrade'])).toBe(1)
+    // A leaked default-surface flag stays a typo even when the gate is passed
+    // by the environment alone.
+    expect(exitCode(['meta', '--resume', 's'], true)).toBe(1)
+    // The flag and the env opt-in may coexist.
+    expect(parse(['meta', '--experimental'], true)).toEqual({ mode: 'meta' })
+    expect(parse(['upgrade', '--experimental'], true)).toEqual({ mode: 'upgrade' })
   })
 
   it('exits 0 for --help (disclosing web) and --version', () => {