From 0fabbd72ad8f4bbb5e453642b8052daa774e6000 Mon Sep 17 00:00:00 2001
From: Tianyi Cui <53024+tianyicui@users.noreply.github.com>
Date: Mon, 27 Jul 2026 23:05:21 +0800
Subject: [PATCH] test(dev-infra): share gate log swap setup

---
 scripts/run-gates.spec.ts | 70 +++++++++++++++++++++------------------
 1 file changed, 38 insertions(+), 32 deletions(-)

diff --git a/scripts/run-gates.spec.ts b/scripts/run-gates.spec.ts
index 46d41a5df8..13a37d0070 100644
--- a/scripts/run-gates.spec.ts
+++ b/scripts/run-gates.spec.ts
@@ -83,6 +83,30 @@ function temporaryRoot(prefix = 'dsh-gate-logs-'): string {
   return root
 }
 
+function invokeGateLogOperation(
+  operation: 'write' | 'prune' | 'clean',
+  subjectGate: Gate,
+  directory: string,
+  root: string,
+  beforeHelper: () => void,
+): Promise<unknown> {
+  switch (operation) {
+    case 'write':
+      return writeGateFailureLog(plan([subjectGate]), resultFor(subjectGate, 'failed'), {
+        directory,
+        repositoryRoot: root,
+        retention: 1,
+        unique: operation,
+        platform: 'linux',
+        beforeHelper,
+      })
+    case 'prune':
+      return pruneGateLogs(directory, 0, root, beforeHelper)
+    case 'clean':
+      return cleanGateFailureLogs(directory, root, beforeHelper)
+  }
+}
+
 function withPnpmEntrypoint<T>(action: () => T): T {
   const previous = process.env.npm_execpath
   process.env.npm_execpath = '/private/pnpm.cjs'
@@ -426,7 +450,6 @@ describe('gate failure logs', () => {
 
   it.skipIf(process.platform === 'win32')('pins write, prune, and cleanup before a concurrent ancestor swap', async () => {
     const subjectGate = gate('subject')
-    const subject = plan([subjectGate])
 
     for (const operation of ['write', 'prune', 'clean'] as const) {
       const auditRoot = temporaryRoot(`dsh-gate-${operation}-swap-`)
@@ -448,21 +471,13 @@ describe('gate failure logs', () => {
         symlinkSync(external, cache, 'dir')
       }
 
-      let invocation: Promise<unknown>
-      if (operation === 'write') {
-        invocation = writeGateFailureLog(subject, resultFor(subjectGate, 'failed'), {
-          directory,
-          repositoryRoot,
-          retention: 1,
-          unique: operation,
-          platform: 'linux',
-          beforeHelper: swapAncestor,
-        })
-      } else if (operation === 'prune') {
-        invocation = pruneGateLogs(directory, 0, repositoryRoot, swapAncestor)
-      } else {
-        invocation = cleanGateFailureLogs(directory, repositoryRoot, swapAncestor)
-      }
+      const invocation = invokeGateLogOperation(
+        operation,
+        subjectGate,
+        directory,
+        repositoryRoot,
+        swapAncestor,
+      )
 
       await expect(invocation).rejects.toThrow('gate-log helper')
       if (victim === undefined) {
@@ -477,7 +492,6 @@ describe('gate failure logs', () => {
 
   it.skipIf(process.platform === 'win32')('rejects a real-directory ancestor moved into place after validation', async () => {
     const subjectGate = gate('subject')
-    const subject = plan([subjectGate])
 
     for (const operation of ['write', 'prune', 'clean'] as const) {
       const auditRoot = temporaryRoot(`dsh-gate-${operation}-real-swap-`)
@@ -497,21 +511,13 @@ describe('gate failure logs', () => {
         renameSync(externalCache, cache)
       }
 
-      let invocation: Promise<unknown>
-      if (operation === 'write') {
-        invocation = writeGateFailureLog(subject, resultFor(subjectGate, 'failed'), {
-          directory,
-          repositoryRoot,
-          retention: 1,
-          unique: operation,
-          platform: 'linux',
-          beforeHelper: swapAncestor,
-        })
-      } else if (operation === 'prune') {
-        invocation = pruneGateLogs(directory, 0, repositoryRoot, swapAncestor)
-      } else {
-        invocation = cleanGateFailureLogs(directory, repositoryRoot, swapAncestor)
-      }
+      const invocation = invokeGateLogOperation(
+        operation,
+        subjectGate,
+        directory,
+        repositoryRoot,
+        swapAncestor,
+      )
 
       await expect(invocation).rejects.toThrow('gate-log helper')
       if (victim === undefined) {