ClearML/go-nvlib
1
0
Fork 0
mirror of https://github.com/clearml/go-nvlib synced 2025-02-07 05:17:43 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Merge branch 'pf-filtering' into 'main'

Browse Source 
Detect if NvidiaPCIDevice is a PF or VF

See merge request nvidia/cloud-native/go-nvlib!13
This commit is contained in:
Christopher Desiniotis 2022-08-15 17:09:02 +00:00
commit 09ae86c8e0
2 changed files with 16 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

16
pkg/nvpci/nvpci.go
View File

@ -75,6 +75,7 @@ type NvidiaPCIDevice struct {
NumaNode int NumaNode int
Config *ConfigSpace Config *ConfigSpace
Resources MemoryResources Resources MemoryResources
IsVF bool
} }
// IsVGAController if class == 0x300 // IsVGAController if class == 0x300
@ -87,7 +88,7 @@ func (d *NvidiaPCIDevice) Is3DController() bool {
return d.Class == PCI3dControllerClass return d.Class == PCI3dControllerClass
} }
// IsNVSwitch if classe == 0x068 // IsNVSwitch if class == 0x068
func (d *NvidiaPCIDevice) IsNVSwitch() bool { func (d *NvidiaPCIDevice) IsNVSwitch() bool {
return d.Class == PCINvSwitchClass return d.Class == PCINvSwitchClass
} }
@ -218,6 +219,16 @@ func NewDevice(devicePath string) (*NvidiaPCIDevice, error) {
return nil, fmt.Errorf("unable to detect iommu_group for %s: %v", address, err) return nil, fmt.Errorf("unable to detect iommu_group for %s: %v", address, err)
} }
// device is a virtual function (VF) if "physfn" symlink exists
var isVF bool
_, err = filepath.EvalSymlinks(path.Join(devicePath, "physfn"))
if err == nil {
isVF = true
}
if err != nil && !os.IsNotExist(err) {
return nil, fmt.Errorf("unable to resolve %s: %v", path.Join(devicePath, "physfn"), err)
}
numa, err := os.ReadFile(path.Join(devicePath, "numa_node")) numa, err := os.ReadFile(path.Join(devicePath, "numa_node"))
if err != nil { if err != nil {
return nil, fmt.Errorf("unable to read PCI NUMA node for %s: %v", address, err) return nil, fmt.Errorf("unable to read PCI NUMA node for %s: %v", address, err)
@ -269,6 +280,7 @@ func NewDevice(devicePath string) (*NvidiaPCIDevice, error) {
NumaNode: int(numaNode), NumaNode: int(numaNode),
Config: config, Config: config,
Resources: resources, Resources: resources,
IsVF: isVF,
} }
return nvdevice, nil return nvdevice, nil
@ -334,7 +346,7 @@ func (p *nvpci) GetGPUs() ([]*NvidiaPCIDevice, error) {
var filtered []*NvidiaPCIDevice var filtered []*NvidiaPCIDevice
for _, d := range devices { for _, d := range devices {
if d.IsGPU() { if d.IsGPU() && !d.IsVF {
filtered = append(filtered, d) filtered = append(filtered, d)
} }
} }

2
pkg/nvpci/nvpci_test.go
View File

@ -64,6 +64,8 @@ func TestNvpci(t *testing.T) {
}() }()
require.Equal(t, int(resource0.End-resource0.Start+1), bar0.Len()) require.Equal(t, int(resource0.End-resource0.Start+1), bar0.Len())
require.Equal(t, ga100PmcID, bar0.Read32(0)) require.Equal(t, ga100PmcID, bar0.Read32(0))
require.Equal(t, devices[0].IsVF, false, "Device incorrectly identified as a VF")
} }
func TestNvpciNUMANode(t *testing.T) { func TestNvpciNUMANode(t *testing.T) {