Matt Johnston
ed79abed76
Don't use // style comments
...
--HG--
extra : convert_revision : c92c7b4fef739b505d9842b45a393e1089097e3b
2008-11-02 12:01:39 +00:00
Matt Johnston
b98d13effb
Don't send anything in response to a SSH_MSG_CHANNEL_REQUEST if we have
...
already sent a SSH_MSG_CHANNEL_CLOSE. This fixes a bug triggered by more
recent versions of putty with tcp fowarding and window adjustment request
messages.
--HG--
extra : convert_revision : 10b2f286b9886364db39dfbb4f8f46e49e345d87
2008-09-23 12:03:01 +00:00
Matt Johnston
6c9d2abc75
Don't return until the shell has quit. This will ensure that an exit status
...
is always returned.
--HG--
extra : convert_revision : 32fc88053016994100eb0ef17f75592881c90d97
2008-02-21 14:46:15 +00:00
Matt Johnston
e3e4445dc1
Add -W <windowsize> argument and document it.
...
--HG--
extra : convert_revision : 98d4c0f15480bf749c451034cbc565d7e9d3b8dc
2007-07-25 15:44:25 +00:00
Matt Johnston
2d4d9627a2
Rearrange the channel buffer sizes into three neat use-editable values in
...
options.h. Increasing RECV_MAX_WINDOW gives big network performance
increases - even with the present buffers (which haven't changed) it
performs a lot better.
Next step is to make the window size a cmdline option.
--HG--
extra : convert_revision : 24c7cb47fb56cf5b82e3bc0859b45ea83038eab0
2007-07-24 15:40:23 +00:00
Matt Johnston
62d792fbdc
Fix a stupid bug s/readfd/errfd/ affecting channel close on child exit
...
--HG--
extra : convert_revision : 16dd04147563e91faaa44de193dece0f4056ec7a
2007-02-22 16:17:09 +00:00
Matt Johnston
7f12251fbb
Fix for -pedantic -ansi compilation, change // to /**/, plus some signedness
...
and trailing-comma-in-array issues
--HG--
extra : convert_revision : c22be8b8f570b48e9662dac32c7b3e7148a42206
2007-02-16 14:42:08 +00:00
Matt Johnston
22440a6fb2
- Fix bug in child-exit handling where the wrong pid was being matched.
...
- Also wait for errfd to close before closing the channel
--HG--
branch : channel-fix
extra : convert_revision : ed68ea8963f7d1fa600f81479e7e211efc5a31bc
2007-02-12 10:39:22 +00:00
Matt Johnston
f5ad5c1553
Improve behaviour when flushing out after a process has exited.
...
--HG--
branch : channel-fix
extra : convert_revision : e73ee8f7ae404a9355685c30828a0ad4524031bc
2007-02-09 10:43:16 +00:00
Matt Johnston
d199e0b119
disapproval of revision '1dfbc5ef92391d01b576c8506061927869a89887'
...
--HG--
branch : channel-fix
extra : convert_revision : 73fe066c5d9e2395354ba74756124d45c978a04d
2007-02-06 15:59:54 +00:00
Matt Johnston
4e09d27c6f
Add some code for testing whether a writefd is closed (by read()ing from it)
...
--HG--
branch : channel-fix
extra : convert_revision : 1dfbc5ef92391d01b576c8506061927869a89887
2006-12-05 15:23:06 +00:00
Matt Johnston
e1d3a8a6e9
- Add some extra tracing.
...
- Be clearer about errfd be used for read versus write with
ERRFD_IS_READ and ERRFD_IS_WRITE macros
--HG--
branch : channel-fix
extra : convert_revision : 8778af05d9573c68b0d859feb7079502b46ed769
2006-12-05 14:42:03 +00:00
Matt Johnston
5b8a26f1d1
Remove accidentally removed block (making sure to close the channel).
...
Other minor cleanups.
--HG--
branch : channel-fix
extra : convert_revision : 7559a8cc4f6abe2338636f2aced3a395a79c172c
2006-10-11 14:44:00 +00:00
Matt Johnston
cc340d9cdc
Passes most test cases now
...
--HG--
branch : channel-fix
extra : convert_revision : 5a5f398411a7a3baa9472daa80fea0574fbd8a9a
2006-10-09 16:31:00 +00:00
Matt Johnston
786ea39ac4
Rearranged (and hopefully simplified) channel close/eof handling
...
--HG--
branch : channel-fix
extra : convert_revision : d44aac5fec50b1d20515da77d410d3c511f16277
2006-10-07 17:48:55 +00:00
Matt Johnston
df57eb3824
Rearranged some more bits, marked some areas that need work.
...
* send_msg_channel_data() no longer allocates a separate buffer
* getchannel() handles unknown channels so callers don't have to
--HG--
branch : channel-fix
extra : convert_revision : 3db645581be0fbb0d2ac8d218fbd55e096cbbbe5
2006-10-02 16:34:06 +00:00
Matt Johnston
7e04c5e277
just shuffle some variables names about, a brief comment
...
about the "bad writefd" problem
--HG--
branch : channel-fix
extra : convert_revision : f0b407c3d3e047ed83174e6f4ebd85a19352df5b
2006-10-01 16:35:13 +00:00
Matt Johnston
4313157666
fix accidentally changed == vs != operators
...
--HG--
extra : convert_revision : a2345a9e53fcb35bde9f3701406e285c1ef80481
2006-06-11 16:37:46 +00:00
Matt Johnston
e8fa3ce478
progress towards exiting on writefd closure rather than
...
on process exit - dbclient hangs with scp, so requires work.
--HG--
extra : convert_revision : 2186a678a5f79ef432f6593a10e3e13df2a313d5
2006-06-11 16:19:32 +00:00
Matt Johnston
c9d3c0bc90
merge of 332f709a4cb39cde4cedab7c3be89e05f3023067
...
and ca4ca78b82c5d430c69ce01bf794e8886ce81431
--HG--
extra : convert_revision : 74020525425a1de06739c6c3bed9ef35e4ad867e
2006-06-10 16:39:40 +00:00
Matt Johnston
94d86427ff
disapproval of revision 'a4c1a9be4db326f8f7adcf30f876fadedf87b203'
...
--HG--
extra : convert_revision : 332f709a4cb39cde4cedab7c3be89e05f3023067
2006-06-10 16:39:37 +00:00
Matt Johnston
1e03393b68
Some cleanups/fixes for various TRACE statements
...
--HG--
extra : convert_revision : 84eb6fedc6df0666f8053b9018bf16635dbfb257
2006-03-25 12:57:37 +00:00
Matt Johnston
e4697de175
merge of 4cbdd6e0a0d8c061075b9ed7609a06c4547f67d3
...
and 5d396842815593611f0d61762440145d1fc74d5a
--HG--
extra : convert_revision : 4c883eb469d2d251ee8abddbc11ae4005db6da17
2006-03-08 12:53:09 +00:00
Matt Johnston
1dc0652444
Stomp on some minor warnings
...
--HG--
extra : convert_revision : 4cbdd6e0a0d8c061075b9ed7609a06c4547f67d3
2006-03-08 12:09:02 +00:00
Matt Johnston
b05ab854ae
Check that the output circular buffer is actually empty before
...
closing the channel (thanks to Tomas Vanek for his help).
--HG--
extra : convert_revision : 7fb3ca52f21072127c9615a5bdbc054c24669e51
2006-01-25 17:13:38 +00:00
Matt Johnston
a4bf09e7b9
* common-channel.c: get rid of the read()-from-writefd code
...
which caused problems when redirecting to or from /dev/null
--HG--
extra : convert_revision : a4c1a9be4db326f8f7adcf30f876fadedf87b203
2005-12-06 17:32:53 +00:00
Matt Johnston
b131f74533
* rename infd/outfd to writefd/readfd, to avoid confusion
...
--HG--
extra : convert_revision : e3e7dc2cf75ad60c83a5b4307c210fee2fe90434
2005-10-20 16:53:12 +00:00
Matt Johnston
18b082955b
* ensure that we only handle open confirmation/failure
...
for channels where it is expected
--HG--
extra : convert_revision : acc1ba014aae08ecb3159282fe87defe67899a40
2005-09-05 17:10:32 +00:00
Matt Johnston
53681cbdb6
* use own assertions which should get logged properly
...
--HG--
extra : convert_revision : 3dc365619f0840ab5781660b1257a9f22c05d3fe
2005-09-05 15:16:10 +00:00
Matt Johnston
5002c95048
* close a file descriptor after we've shutdown() both sides, to avoid a leak
...
--HG--
extra : convert_revision : 06fda32c634cf16a4c75797441ec2bd533f571c6
2005-07-08 15:04:06 +00:00
Matt Johnston
298a5717bc
compile fix when TRACE debugging is enabled
...
--HG--
extra : convert_revision : 7844ac7e5a24b88231de2af7520c49e56820a87c
2005-05-04 15:31:17 +00:00
Matt Johnston
f45eafe342
* fix longstanding bug with connections being closed on failure to
...
connect to auth socket (server)
* differentiate between get_byte and get_bool
* get rid of some // comments
* general tidying
--HG--
extra : convert_revision : fb8d188ce33b6b45804a5ce51b9f601f83bdf3d7
2005-03-13 13:58:14 +00:00
Matt Johnston
8c1a429c44
Fixed DEBUG_TRACE macro so that we don't get semicolons left about the place
...
--HG--
extra : convert_revision : d928bc851e32be7bd429bf7504b148c0e4bf7e2f
2005-01-02 20:25:56 +00:00
Matt Johnston
e7677a5e8d
Rearrange preprocessor parts so that compilation with various options
...
disabled works OK.
--HG--
extra : convert_revision : cc92f744e34125062d052b757967e167f19d6db5
2004-12-22 15:37:50 +00:00
Matt Johnston
69282617fd
merge of 50be59810e462f9f44f55e421227d6aa0b31982b
...
and 69b007796063cb5f042be7cca2d479e90db869c3
--HG--
extra : convert_revision : 5d0dfaa8c0ee6c728a3b4f0f0855199ba729db83
2004-08-27 14:39:01 +00:00
Matt Johnston
51a74b4799
- added circular buffering for channels
...
- added stderr support for the client
- cleaned up a bunch of "unused" warnings, duplicated header definitions
- added exit-status support for the client
--HG--
extra : convert_revision : 5bdf806d8b440c87f7235414662f4189195618f4
2004-08-26 13:16:40 +00:00
Matt Johnston
2dcd6b22d9
Nasty.
...
--HG--
extra : convert_revision : e1229cd01c3007206d2937ea390ad4966c289a5a
2004-08-24 18:12:18 +00:00
Matt Johnston
8e1ec24f55
Merging in the changes from 0.41-0.43 main Dropbear tree
...
--HG--
extra : convert_revision : 4c3428781bc8faf0fd7cadd7099fbd7f4ea386e7
2004-08-12 16:41:58 +00:00
Matt Johnston
a712baa8e5
just checkpointing
...
--HG--
extra : convert_revision : fbbf404290f3fea3dfa9f6f53eba9389057e9044
2004-08-10 17:09:52 +00:00
Matt Johnston
b601f68cda
we're nearly there yet
...
--HG--
extra : convert_revision : ab7e63234f2c134c2321406598ae67038e0ca576
2004-07-30 03:02:19 +00:00
Matt Johnston
ae1b0b07cf
Fixed stupid agentfwd error (using the listening FD, not the accepted on. gah)
...
--HG--
extra : convert_revision : 27e793a6395dbf5f2c0aa130d37fad2e4ef67e01
2004-06-03 18:08:34 +00:00
Matt Johnston
444dbb5364
- Reworked non-channel fd handling to listener.c
...
- More channel cleaning up
--HG--
extra : convert_revision : 385ec76d0304b93e277d1cc193383db5fd773703
2004-06-03 16:45:53 +00:00
Matt Johnston
513f947d62
Chantype handling is sorted
...
--HG--
extra : convert_revision : 807efead6ecf690f147fd8145aa9d78ff894cdb2
2004-06-02 04:59:49 +00:00
Matt Johnston
6152263045
Sorted out the first channel init issues.
...
--HG--
extra : convert_revision : 67676f36b78efac878c11943d78a5de827498d05
2004-06-01 10:48:46 +00:00
Matt Johnston
674a607488
Makefile.in contains updated files required
...
--HG--
extra : convert_revision : cc8a8c49dc70e632c352853a39801089b08149be
2004-06-01 02:46:09 +00:00