From c4a0304b3f79349eb8c72c7e97e93c16e3c3d3bb Mon Sep 17 00:00:00 2001 From: Matt Johnston Date: Sat, 23 Apr 2022 22:54:39 +0800 Subject: [PATCH] Add a test for off-by-default compile options This would have caught broken x11 (gh #156) --- .github/workflows/build.yml | 15 ++++++++++++++- 1 file changed, 14 insertions(+), 1 deletion(-) diff --git a/.github/workflows/build.yml b/.github/workflows/build.yml index 89db61e..dfe5084 100644 --- a/.github/workflows/build.yml +++ b/.github/workflows/build.yml @@ -74,6 +74,11 @@ jobs: localoptions: | #define DEBUG_TRACE 5 + # Check off-by-default options don't bitrot + - name: nondefault options + nondefault: 1 + configure_flags: --enable-pam + # # Fuzzers run standalone. A bit superfluous with cifuzz, but # # good to run the whole corpus to keep it working. # - name: fuzzing with address sanitizer @@ -115,7 +120,7 @@ jobs: if: ${{ matrix.apt != 'no' }} run: | sudo apt-get -y update - sudo apt-get -y install zlib1g-dev libtomcrypt-dev libtommath-dev mercurial python3-venv $CC + sudo apt-get -y install zlib1g-dev libtomcrypt-dev libtommath-dev mercurial python3-venv libpam0g-dev $CC - uses: actions/checkout@v2 @@ -131,6 +136,14 @@ jobs: echo "$LOCALOPTIONS" > localoptions.h cat localoptions.h + - name: nondefault + if: ${{ matrix.nondefault }} + run: | + # Turn on anything that's off by default. Rough but seems sufficient + grep ' 0$' default_options.h | sed 's/0$/1/' > localoptions.h + # PAM clashes with password + echo "#define DROPBEAR_SVR_PASSWORD_AUTH 0" >> localoptions.h + - name: make run: make -j3