mirror of
https://github.com/clearml/dropbear
synced 2025-03-03 18:52:00 +00:00
- Sockets are set to lowdelay priority initially to improve conneciton setup
time - Set non-pty connections to bulk for client and server
This commit is contained in:
parent
ddc10b2d0c
commit
998d6cdfc4
@ -369,7 +369,8 @@ static int cli_initchansess(struct Channel *channel) {
|
|||||||
|
|
||||||
if (cli_opts.wantpty) {
|
if (cli_opts.wantpty) {
|
||||||
send_chansess_pty_req(channel);
|
send_chansess_pty_req(channel);
|
||||||
set_sock_priority(ses.sock_out);
|
} else {
|
||||||
|
set_sock_priority(ses.sock_out, DROPBEAR_PRIO_BULK);
|
||||||
}
|
}
|
||||||
|
|
||||||
send_chansess_shell_req(channel);
|
send_chansess_shell_req(channel);
|
||||||
|
@ -75,6 +75,9 @@ int main(int argc, char ** argv) {
|
|||||||
int sock = connect_remote(cli_opts.remotehost, cli_opts.remoteport,
|
int sock = connect_remote(cli_opts.remotehost, cli_opts.remoteport,
|
||||||
0, &error);
|
0, &error);
|
||||||
sock_in = sock_out = sock;
|
sock_in = sock_out = sock;
|
||||||
|
if (cli_opts.wantpty) {
|
||||||
|
set_sock_priority(sock, DROPBEAR_PRIO_LOWDELAY);
|
||||||
|
}
|
||||||
}
|
}
|
||||||
|
|
||||||
if (sock_in < 0) {
|
if (sock_in < 0) {
|
||||||
|
37
dbutil.c
37
dbutil.c
@ -185,30 +185,37 @@ void set_sock_nodelay(int sock) {
|
|||||||
setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, (void*)&val, sizeof(val));
|
setsockopt(sock, IPPROTO_TCP, TCP_NODELAY, (void*)&val, sizeof(val));
|
||||||
}
|
}
|
||||||
|
|
||||||
void set_sock_priority(int sock) {
|
void set_sock_priority(int sock, enum dropbear_prio prio) {
|
||||||
|
|
||||||
int val, rc;
|
int iptos_val = 0, so_prio_val = 0, rc;
|
||||||
|
|
||||||
/* set the TOS bit for either ipv4 or ipv6 */
|
/* set the TOS bit for either ipv4 or ipv6 */
|
||||||
#ifdef IPTOS_LOWDELAY
|
#ifdef IPTOS_LOWDELAY
|
||||||
val = IPTOS_LOWDELAY;
|
if (prio == DROPBEAR_PRIO_LOWDELAY) {
|
||||||
|
iptos_val = IPTOS_LOWDELAY;
|
||||||
|
} else if (prio == DROPBEAR_PRIO_BULK) {
|
||||||
|
iptos_val = IPTOS_THROUGHPUT;
|
||||||
|
}
|
||||||
#if defined(IPPROTO_IPV6) && defined(IPV6_TCLASS)
|
#if defined(IPPROTO_IPV6) && defined(IPV6_TCLASS)
|
||||||
rc = setsockopt(sock, IPPROTO_IPV6, IPV6_TCLASS, (void*)&val, sizeof(val));
|
rc = setsockopt(sock, IPPROTO_IPV6, IPV6_TCLASS, (void*)&iptos_val, sizeof(iptos_val));
|
||||||
if (rc < 0)
|
if (rc < 0) {
|
||||||
dropbear_log(LOG_WARNING, "Couldn't set IPV6_TCLASS (%s)",
|
TRACE(("Couldn't set IPV6_TCLASS (%s)", strerror(errno)));
|
||||||
strerror(errno));
|
}
|
||||||
#endif
|
#endif
|
||||||
rc = setsockopt(sock, IPPROTO_IP, IP_TOS, (void*)&val, sizeof(val));
|
rc = setsockopt(sock, IPPROTO_IP, IP_TOS, (void*)&iptos_val, sizeof(iptos_val));
|
||||||
if (rc < 0)
|
if (rc < 0) {
|
||||||
dropbear_log(LOG_WARNING, "Couldn't set IP_TOS (%s)",
|
TRACE(("Couldn't set IP_TOS (%s)", strerror(errno)));
|
||||||
strerror(errno));
|
}
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
#ifdef SO_PRIORITY
|
#ifdef SO_PRIORITY
|
||||||
/* linux specific, sets QoS class.
|
if (prio == DROPBEAR_PRIO_LOWDELAY) {
|
||||||
* 6 looks to be optimal for interactive traffic (see tc-prio(8) ). */
|
so_prio_val = TC_PRIO_INTERACTIVE;
|
||||||
val = TC_PRIO_INTERACTIVE;
|
} else if (prio == DROPBEAR_PRIO_BULK) {
|
||||||
rc = setsockopt(sock, SOL_SOCKET, SO_PRIORITY, (void*) &val, sizeof(val));
|
so_prio_val = TC_PRIO_BULK;
|
||||||
|
}
|
||||||
|
/* linux specific, sets QoS class. see tc-prio(8) */
|
||||||
|
rc = setsockopt(sock, SOL_SOCKET, SO_PRIORITY, (void*) &so_prio_val, sizeof(so_prio_val));
|
||||||
if (rc < 0)
|
if (rc < 0)
|
||||||
dropbear_log(LOG_WARNING, "Couldn't set SO_PRIORITY (%s)",
|
dropbear_log(LOG_WARNING, "Couldn't set SO_PRIORITY (%s)",
|
||||||
strerror(errno));
|
strerror(errno));
|
||||||
|
8
dbutil.h
8
dbutil.h
@ -61,13 +61,19 @@ void printmpint(const char *label, mp_int *mp);
|
|||||||
extern int debug_trace;
|
extern int debug_trace;
|
||||||
#endif
|
#endif
|
||||||
|
|
||||||
|
enum dropbear_prio {
|
||||||
|
DROPBEAR_PRIO_DEFAULT,
|
||||||
|
DROPBEAR_PRIO_LOWDELAY,
|
||||||
|
DROPBEAR_PRIO_BULK,
|
||||||
|
};
|
||||||
|
|
||||||
char * stripcontrol(const char * text);
|
char * stripcontrol(const char * text);
|
||||||
void get_socket_address(int fd, char **local_host, char **local_port,
|
void get_socket_address(int fd, char **local_host, char **local_port,
|
||||||
char **remote_host, char **remote_port, int host_lookup);
|
char **remote_host, char **remote_port, int host_lookup);
|
||||||
void getaddrstring(struct sockaddr_storage* addr,
|
void getaddrstring(struct sockaddr_storage* addr,
|
||||||
char **ret_host, char **ret_port, int host_lookup);
|
char **ret_host, char **ret_port, int host_lookup);
|
||||||
void set_sock_nodelay(int sock);
|
void set_sock_nodelay(int sock);
|
||||||
void set_sock_priority(int sock);
|
void set_sock_priority(int sock, enum dropbear_prio prio);
|
||||||
int dropbear_listen(const char* address, const char* port,
|
int dropbear_listen(const char* address, const char* port,
|
||||||
int *socks, unsigned int sockcount, char **errstring, int *maxfd);
|
int *socks, unsigned int sockcount, char **errstring, int *maxfd);
|
||||||
int spawn_command(void(*exec_fn)(void *user_data), void *exec_data,
|
int spawn_command(void(*exec_fn)(void *user_data), void *exec_data,
|
||||||
|
@ -580,8 +580,6 @@ static int sessionpty(struct ChanSess * chansess) {
|
|||||||
/* Read the terminal modes */
|
/* Read the terminal modes */
|
||||||
get_termmodes(chansess);
|
get_termmodes(chansess);
|
||||||
|
|
||||||
set_sock_priority(ses.sock_out);
|
|
||||||
|
|
||||||
TRACE(("leave sessionpty"))
|
TRACE(("leave sessionpty"))
|
||||||
return DROPBEAR_SUCCESS;
|
return DROPBEAR_SUCCESS;
|
||||||
}
|
}
|
||||||
@ -666,6 +664,7 @@ static int sessioncommand(struct Channel *channel, struct ChanSess *chansess,
|
|||||||
|
|
||||||
if (chansess->term == NULL) {
|
if (chansess->term == NULL) {
|
||||||
/* no pty */
|
/* no pty */
|
||||||
|
set_sock_priority(ses.sock_out, DROPBEAR_PRIO_BULK);
|
||||||
ret = noptycommand(channel, chansess);
|
ret = noptycommand(channel, chansess);
|
||||||
} else {
|
} else {
|
||||||
/* want pty */
|
/* want pty */
|
||||||
|
@ -137,6 +137,11 @@ void main_noinetd() {
|
|||||||
dropbear_exit("No listening ports available.");
|
dropbear_exit("No listening ports available.");
|
||||||
}
|
}
|
||||||
|
|
||||||
|
for (i = 0; i < listensockcount; i++) {
|
||||||
|
set_sock_priority(listensocks[i], DROPBEAR_PRIO_LOWDELAY);
|
||||||
|
FD_SET(listensocks[i], &fds);
|
||||||
|
}
|
||||||
|
|
||||||
/* fork */
|
/* fork */
|
||||||
if (svr_opts.forkbg) {
|
if (svr_opts.forkbg) {
|
||||||
int closefds = 0;
|
int closefds = 0;
|
||||||
|
Loading…
Reference in New Issue
Block a user