ClearML/dropbear
1
0
Fork 0
mirror of https://github.com/clearml/dropbear synced 2025-03-03 18:52:00 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Integrity error (bad packet size %u) negative length

Browse Source 
When corrupted packet is received negative length of packet is
    displayed.
    (re-apply of pull request #8)
This commit is contained in:
Fedor Brunner 2015-01-23 22:21:06 +08:00
parent 1ed8d3938e
commit 7b2c42aa75
1 changed files with 3 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
packet.c
View File

@ -283,14 +283,14 @@ static int read_packet_init() {
} }
len = buf_getint(ses.readbuf) + 4 + macsize; len = buf_getint(ses.readbuf) + 4 + macsize;
TRACE2(("packet size is %d, block %d mac %d", len, blocksize, macsize)) TRACE2(("packet size is %u, block %u mac %u", len, blocksize, macsize))
/* check packet length */ /* check packet length */
if ((len > RECV_MAX_PACKET_LEN) || if ((len > RECV_MAX_PACKET_LEN) ||
(len < MIN_PACKET_LEN + macsize) || (len < MIN_PACKET_LEN + macsize) ||
((len - macsize) % blocksize != 0)) { ((len - macsize) % blocksize != 0)) {
dropbear_exit("Integrity error (bad packet size %d)", len); dropbear_exit("Integrity error (bad packet size %u)", len);
} }
if (len > ses.readbuf->size) { if (len > ses.readbuf->size) {
@ -342,7 +342,7 @@ void decrypt_packet() {
/* - 4 - 1 is for LEN and PADLEN values */ /* - 4 - 1 is for LEN and PADLEN values */
len = ses.readbuf->len - padlen - 4 - 1 - macsize; len = ses.readbuf->len - padlen - 4 - 1 - macsize;
if ((len > RECV_MAX_PAYLOAD_LEN+ZLIB_COMPRESS_EXPANSION) || (len < 1)) { if ((len > RECV_MAX_PAYLOAD_LEN+ZLIB_COMPRESS_EXPANSION) || (len < 1)) {
dropbear_exit("Bad packet size %d", len); dropbear_exit("Bad packet size %u", len);
} }
buf_setpos(ses.readbuf, PACKET_PAYLOAD_OFF); buf_setpos(ses.readbuf, PACKET_PAYLOAD_OFF);