From 17be46e229a108d115afe97715e3110aac638dd6 Mon Sep 17 00:00:00 2001 From: Matt Johnston Date: Thu, 15 Feb 2018 23:30:54 +0800 Subject: [PATCH 1/2] disallow inetd -v --- svr-main.c | 7 +++++++ 1 file changed, 7 insertions(+) diff --git a/svr-main.c b/svr-main.c index ea19d2d..4d82ec1 100644 --- a/svr-main.c +++ b/svr-main.c @@ -83,6 +83,13 @@ static void main_inetd() { /* Set up handlers, syslog, seed random */ commonsetup(); +#if DEBUG_TRACE + if (debug_trace) { + /* -v output goes to stderr which would get sent over the inetd network socket */ + dropbear_exit(LOG_ERR, "Dropbear inetd mode is incompatible with debug -v"); + } +#endif + /* In case our inetd was lax in logging source addresses */ get_socket_address(0, NULL, NULL, &host, &port, 0); dropbear_log(LOG_INFO, "Child connection from %s:%s", host, port); From e0748b19700a0673dc35a632a158ccbd96f9b88c Mon Sep 17 00:00:00 2001 From: Matt Johnston Date: Fri, 16 Feb 2018 23:17:15 +0800 Subject: [PATCH 2/2] Remove accidentally committed DROPBEAR_FUZZ --- svr-authpubkey.c | 8 -------- 1 file changed, 8 deletions(-) diff --git a/svr-authpubkey.c b/svr-authpubkey.c index 8905ac9..aa6087c 100644 --- a/svr-authpubkey.c +++ b/svr-authpubkey.c @@ -473,12 +473,4 @@ static int checkfileperm(char * filename) { return DROPBEAR_SUCCESS; } -#ifdef DROPBEAR_FUZZ -int fuzz_checkpubkey_line(buffer* line, int line_num, char* filename, - const char* algo, unsigned int algolen, - const unsigned char* keyblob, unsigned int keybloblen) { - return checkpubkey_line(line, line_num, filename, algo, algolen, keyblob, keybloblen); -} -#endif - #endif