ClearML/dropbear
1
0
Fork 0
mirror of https://github.com/clearml/dropbear synced 2025-01-31 02:46:58 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

use buf_getptr and m_free on every iteration before m_malloc to insure no memory leaks are happening

Browse Source
This commit is contained in:
HansH111 2022-03-15 18:57:21 +00:00
parent 35631a21a2
commit 212583544a
1 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
svr-authpubkey.c
View File

@ -356,6 +356,11 @@ static int checkpubkey_line(buffer* line, int line_num, const char* filename,
ret = cmp_base64_key(keyblob, keybloblen, (const unsigned char *) algo, algolen, line, NULL);
/* free pubkey_info if it is filled */
if (ses.authstate.pubkey_info) {
m_free(ses.authstate.pubkey_info);
ses.authstate.pubkey_info = NULL;
}
if (ret == DROPBEAR_SUCCESS) {
if (options_buf) {
ret = svr_add_pubkey_options(options_buf, line_num, filename);
@ -364,11 +369,9 @@ static int checkpubkey_line(buffer* line, int line_num, const char* filename,
if (infolen) {
ses.authstate.pubkey_info = m_malloc(infolen + 1);
if (ses.authstate.pubkey_info) {
strncpy(ses.authstate.pubkey_info, &line->data[infopos], infolen);
strncpy(ses.authstate.pubkey_info,(const char *) buf_getptr(line, infopos), infolen);
ses.authstate.pubkey_info[infolen]='\0';
}
} else {
ses.authstate.pubkey_info = NULL;
}
}