ClearML/dropbear
1
0
Fork 0
mirror of https://github.com/clearml/dropbear synced 2025-03-06 12:02:51 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Partial strings from strtoul should return error

Browse Source
This commit is contained in:
Matt Johnston 2021-10-12 23:31:09 +08:00
parent c08177a3af
commit 110b55214b
1 changed files with 9 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

11
dbutil.c
View File

@ -583,8 +583,15 @@ void disallow_core() {
/* Returns DROPBEAR_SUCCESS or DROPBEAR_FAILURE, with the result in *val */
int m_str_to_uint(const char* str, unsigned int *val) {
unsigned long l;
errno = 0;
l = strtoul(str, NULL, 10);
char *endp;
l = strtoul(str, &endp, 10);
if (endp == str || *endp != '\0') {
// parse error
return DROPBEAR_FAILURE;
}
/* The c99 spec doesn't actually seem to define EINVAL, but most platforms
* I've looked at mention it in their manpage */
if ((l == 0 && errno == EINVAL)