From e7f4497e3634aa9d55e8f18b9e7efd299794b4ee Mon Sep 17 00:00:00 2001 From: allegroai <> Date: Sun, 5 Nov 2023 21:03:14 +0200 Subject: [PATCH] Fix potential threading issues when setting self.lock to None --- clearml/backend_interface/task/log.py | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/clearml/backend_interface/task/log.py b/clearml/backend_interface/task/log.py index 9f348cdc..9e67cd38 100644 --- a/clearml/backend_interface/task/log.py +++ b/clearml/backend_interface/task/log.py @@ -263,8 +263,8 @@ class TaskHandler(BufferingHandler): # flush pending logs if not self._task_id: return - # avoid deadlocks just skip the lock, we are shutting down anyway - self.lock = None + # Never null the lock, it might be used by internal Python at some point + # self.lock = None self._task_id = None # shut down the TaskHandler, from this point onwards. No events will be logged