ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-03-16 00:17:15 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix checking backend api version lower than the supported version is meaningless

Browse Source
This commit is contained in:
allegroai 2022-11-21 16:30:37 +02:00
parent 9713f63cb7
commit d9497dd603
1 changed files with 9 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
clearml/backend_api/session/session.py
View File

@ -74,7 +74,7 @@ class Session(TokenManager):
_client = [(__package__.partition(".")[0], __version__)] _client = [(__package__.partition(".")[0], __version__)]
api_version = '2.9' api_version = '2.9' # this default version should match the lowest api version we have under service
max_api_version = '2.9' max_api_version = '2.9'
feature_set = 'basic' feature_set = 'basic'
default_demo_host = "https://demoapi.demo.clear.ml" default_demo_host = "https://demoapi.demo.clear.ml"
@ -227,11 +227,12 @@ class Session(TokenManager):
# notice: this is across the board warning omission # notice: this is across the board warning omission
urllib_log_warning_setup(total_retries=http_retries_config.get('total', 0), display_warning_after=3) urllib_log_warning_setup(total_retries=http_retries_config.get('total', 0), display_warning_after=3)
self.__class__._sessions_created += 1
if self.force_max_api_version and self.check_min_api_version(self.force_max_api_version): if self.force_max_api_version and self.check_min_api_version(self.force_max_api_version):
Session.max_api_version = Session.api_version = str(self.force_max_api_version) Session.max_api_version = Session.api_version = str(self.force_max_api_version)
# update only after we have max_api
self.__class__._sessions_created += 1
self._load_vaults() self._load_vaults()
self._apply_config_sections(local_logger) self._apply_config_sections(local_logger)
@ -676,6 +677,11 @@ class Session(TokenManager):
pass pass
cls.max_api_version = cls.api_version = cls._offline_default_version cls.max_api_version = cls.api_version = cls._offline_default_version
else: else:
# if the requested version is lower then the minium we support,
# no need to actually check what the server has, we assume it must have at least our version.
if cls._version_tuple(cls.api_version) >= cls._version_tuple(str(min_api_version)):
return True
# noinspection PyBroadException # noinspection PyBroadException
try: try:
cls() cls()