ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-03-03 18:52:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Clarify deferred_init usage in Task.init() (#855)

Browse Source
This commit is contained in:
allegroai 2022-12-22 21:45:57 +02:00
parent 72d9b22e0d
commit bf37df61aa
2 changed files with 6 additions and 7 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
clearml/backend_interface/task/task.py
View File

@ -81,6 +81,8 @@ class Task(IdObjectBase, AccessMixin, SetupUploadMixin):
__default_random_seed = 1337 __default_random_seed = 1337
_random_seed = __default_random_seed _random_seed = __default_random_seed
__nested_deferred_init_flag = type('_NestedDeferredInitFlag', (object,), {'content': {}})
class TaskTypes(Enum): class TaskTypes(Enum):
def __str__(self): def __str__(self):
return str(self.value) return str(self.value)

11
clearml/task.py
View File

@ -491,9 +491,7 @@ class Task(_Task):
) )
) )
# if deferred_init==0 this means this is the nested call that actually generates the Task.init if cls.__main_task is not None and deferred_init != cls.__nested_deferred_init_flag:
# notice isinstance(False, int) is always True, so we have to check type (we wanted deferred_init != 0)
if cls.__main_task is not None and (not (type(deferred_init) == int and deferred_init == 0)):
# if this is a subprocess, regardless of what the init was called for, # if this is a subprocess, regardless of what the init was called for,
# we have to fix the main task hooks and stdout bindings # we have to fix the main task hooks and stdout bindings
if cls.__forked_proc_main_pid != os.getpid() and cls.__is_subprocess(): if cls.__forked_proc_main_pid != os.getpid() and cls.__is_subprocess():
@ -561,10 +559,9 @@ class Task(_Task):
if not running_remotely(): if not running_remotely():
# only allow if running locally and creating the first Task # only allow if running locally and creating the first Task
# otherwise we ignore and perform in order # otherwise we ignore and perform in order
# notice isinstance(False, int) is always True, so we have to check type (we wanted deferred_init != 0) if ENV_DEFERRED_TASK_INIT.get():
if (not (type(deferred_init) == int and deferred_init == 0)) and ENV_DEFERRED_TASK_INIT.get():
deferred_init = True deferred_init = True
if not is_sub_process_task_id and deferred_init: if not is_sub_process_task_id and deferred_init and deferred_init != cls.__nested_deferred_init_flag:
def completed_cb(x): def completed_cb(x):
Task.__main_task = x Task.__main_task = x
@ -584,7 +581,7 @@ class Task(_Task):
auto_connect_frameworks=auto_connect_frameworks, auto_connect_frameworks=auto_connect_frameworks,
auto_resource_monitoring=auto_resource_monitoring, auto_resource_monitoring=auto_resource_monitoring,
auto_connect_streams=auto_connect_streams, auto_connect_streams=auto_connect_streams,
deferred_init=0, # notice we use it as a flag to mark the nested call deferred_init=cls.__nested_deferred_init_flag,
) )
is_deferred = True is_deferred = True
# mark as temp master # mark as temp master