From a2557c253cd6a9f4f0992995c1fbdd6ce3ad87ef Mon Sep 17 00:00:00 2001
From: allegroai <>
Date: Sat, 27 Feb 2021 23:52:14 +0200
Subject: [PATCH] Disable progress upload callback at the end of http driver
 upload until we have full upload progress

---
 clearml/storage/helper.py | 12 +++++++-----
 1 file changed, 7 insertions(+), 5 deletions(-)

diff --git a/clearml/storage/helper.py b/clearml/storage/helper.py
index b2a521a5..b3a8beb0 100644
--- a/clearml/storage/helper.py
+++ b/clearml/storage/helper.py
@@ -1031,11 +1031,13 @@ class _HttpDriver(_Driver):
         if res.status_code != requests.codes.ok:
             raise ValueError('Failed uploading object %s (%d): %s' % (object_name, res.status_code, res.text))
 
-        if callback and stream_size:
-            try:
-                callback(stream_size)
-            except Exception as ex:
-                log.debug('Exception raised when running callback function: %s' % ex)
+        # call back is useless because we are not calling it while uploading...
+
+        # if callback and stream_size:
+        #     try:
+        #         callback(stream_size)
+        #     except Exception as ex:
+        #         log.debug('Exception raised when running callback function: %s' % ex)
         return res
 
     def list_container_objects(self, *args, **kwargs):