From 98ce0bbe435626eb1c31c6c7305b5e8cde8c0918 Mon Sep 17 00:00:00 2001
From: allegroai <>
Date: Thu, 9 Apr 2020 12:39:09 +0300
Subject: [PATCH] Change TaskHandler.close() wait default to False as it should
 not wait for logs to flush

---
 trains/backend_interface/task/log.py | 4 ++--
 trains/logger.py                     | 6 +-----
 trains/task.py                       | 4 ----
 3 files changed, 3 insertions(+), 11 deletions(-)

diff --git a/trains/backend_interface/task/log.py b/trains/backend_interface/task/log.py
index de4cbf0b..1ee01268 100644
--- a/trains/backend_interface/task/log.py
+++ b/trains/backend_interface/task/log.py
@@ -153,7 +153,7 @@ class TaskHandler(BufferingHandler):
         self.release()
         ll(msg % 11)
 
-    def close(self, wait=True):
+    def close(self, wait=False):
         # super already calls self.flush()
         super(TaskHandler, self).close()
         # shut down the TaskHandler, from this point onwards. No events will be logged
@@ -168,7 +168,7 @@ class TaskHandler(BufferingHandler):
     def _send_events(self, a_request):
         try:
             if self._thread_pool is None:
-                self.__log_stderr('WARNING: trains.Task - '
+                self.__log_stderr('INFO: trains.Task - '
                                   'Task.close() flushing remaining logs ({})'.format(self._pending))
             self._pending -= 1
             res = self.session.send(a_request)
diff --git a/trains/logger.py b/trains/logger.py
index dad54cac..9c0286d7 100644
--- a/trains/logger.py
+++ b/trains/logger.py
@@ -723,11 +723,7 @@ class Logger(object):
         )
 
     def _start_task_if_needed(self):
-        # do not refresh the task status read from cached variable _status
-        # if str(self._task._status) == str(tasks.TaskStatusEnum.created):
-        #     self._task.mark_started()
-        #
-        # self._task._dev_mode_task_start()
+        # deprecated
         pass
 
     def _flush_stdout_handler(self):
diff --git a/trains/task.py b/trains/task.py
index 4446dbb3..a86c8b13 100644
--- a/trains/task.py
+++ b/trains/task.py
@@ -770,8 +770,6 @@ class Task(_Task):
         # store is main before we call at_exit, because will will Null it
         is_main = self.is_main_task()
         self._at_exit()
-        # leave _at_exit_called set to True (I think)
-        ## self._at_exit_called = False
         # unregister atexit callbacks and signal hooks, if we are the main task
         if is_main:
             self.__register_at_exit(None)
@@ -1582,8 +1580,6 @@ class Task(_Task):
             except Exception:
                 pass
             self._edit_lock = None
-        # HACK FOR TRACE
-        self.is_main_task()
 
     @classmethod
     def __register_at_exit(cls, exit_callback, only_remove_signal_and_exception_hooks=False):