ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-04-22 07:15:57 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix HBandster to not shutdown namespace manually as Pyro will shut it down for us

Browse Source
This commit is contained in:
allegroai 2020-07-14 23:37:41 +03:00
parent 4e1d2b0f4a
commit 84bdac5cc8
1 changed files with 3 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

5
trains/automation/hpbandster/bandster.py
View File

@ -164,7 +164,7 @@ class OptimizerBOHB(SearchStrategy, RandomSeed):
:param float time_limit_per_job: Optional, maximum execution time per single job in minutes, :param float time_limit_per_job: Optional, maximum execution time per single job in minutes,
when time limit is exceeded job is aborted when time limit is exceeded job is aborted
:param int local_port: default port 9090 tcp, this is a must for the BOHB workers to communicate, even locally. :param int local_port: default port 9090 tcp, this is a must for the BOHB workers to communicate, even locally.
:param bohb_kwargs: arguments passed directly yo the BOHB object :param bohb_kwargs: arguments passed directly to the BOHB object
""" """
if not max_iteration_per_job or not min_iteration_per_job or not total_max_jobs: if not max_iteration_per_job or not min_iteration_per_job or not total_max_jobs:
raise ValueError( raise ValueError(
@ -323,7 +323,8 @@ class OptimizerBOHB(SearchStrategy, RandomSeed):
""" """
# After the optimizer run, we must shutdown the master and the nameserver. # After the optimizer run, we must shutdown the master and the nameserver.
self._bohb.shutdown(shutdown_workers=True) self._bohb.shutdown(shutdown_workers=True)
self._namespace.shutdown() # no need to specifically shutdown the name server, hopefully pyro will do that
# self._namespace.shutdown()
if not self._res: if not self._res:
return return