From 82009a5935cfe89fec5f3b0b54f639a921489690 Mon Sep 17 00:00:00 2001 From: allegroai <> Date: Fri, 23 Jul 2021 16:00:23 +0300 Subject: [PATCH] Fix check permissions fail in HTTPDriver (issue #394) --- clearml/storage/helper.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/clearml/storage/helper.py b/clearml/storage/helper.py index ec4eb9ec..7252b0dc 100644 --- a/clearml/storage/helper.py +++ b/clearml/storage/helper.py @@ -759,7 +759,7 @@ class StorageHelper(object): return self._driver.delete_object(self._get_object(path)) def check_write_permissions(self, dest_path=None): - # create a temporary file, then de;ete it + # create a temporary file, then delete it base_url = dest_path or self._base_url dest_path = base_url + '/.clearml.test' # do not check http/s connection permissions @@ -1055,7 +1055,8 @@ class _HttpDriver(_Driver): container = self._containers[obj.container_name] res = container.session.delete(obj.url, headers=container.get_headers(obj.url)) if res.status_code != requests.codes.ok: - raise ValueError('Failed deleting object %s (%d): %s' % (obj.object_name, res.status_code, res.text)) + log.warning('Failed deleting object %s (%d): %s' % (obj.object_name, res.status_code, res.text)) + return False return True def get_object(self, container_name, object_name, *args, **kwargs):