ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-02-01 09:36:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix crash in Dataset.upload() when there is nothing to upload (#579)

Browse Source
This commit is contained in:
eugen-ajechiloae-clearml 2022-02-21 15:54:42 +02:00 committed by GitHub
parent 2ecf0b55f9
commit 76559b6e2d
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 10 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

14
clearml/datasets/dataset.py
View File

@ -398,14 +398,14 @@ class Dataset(object):
if not count: if not count:
zip_file.unlink() zip_file.unlink()
else:
total_size += zip_file.stat().st_size total_size += zip_file.stat().st_size
# let's see what's left
list_file_entries = list_file_entries[processed:]
# update the artifact preview # update the artifact preview
archive_preview = 'Dataset archive content [{} files]:\n'.format(count) + archive_preview archive_preview = "Dataset archive content [{} files]:\n".format(count) + archive_preview
# add into the list # add into the list
list_zipped_artifacts += [(zip_file, count, archive_preview, self._data_artifact_name)] list_zipped_artifacts += [(zip_file, count, archive_preview, self._data_artifact_name)]
# let's see what's left
list_file_entries = list_file_entries[processed:]
# next artifact name to use # next artifact name to use
self._data_artifact_name = self._get_next_data_artifact_name(self._data_artifact_name) self._data_artifact_name = self._get_next_data_artifact_name(self._data_artifact_name)
@ -413,10 +413,12 @@ class Dataset(object):
a_tqdm.close() a_tqdm.close()
self._task.get_logger().report_text( self._task.get_logger().report_text(
'File compression completed: total size {}, {} chunked stored (average size {})'.format( "File compression completed: total size {}, {} chunked stored (average size {})".format(
format_size(total_size), format_size(total_size),
len(list_zipped_artifacts), len(list_zipped_artifacts),
format_size(total_size / len(list_zipped_artifacts)))) format_size(0 if len(list_zipped_artifacts) == 0 else total_size / len(list_zipped_artifacts)),
)
)
if not list_zipped_artifacts: if not list_zipped_artifacts:
LoggerRoot.get_base_logger().info('No pending files, skipping upload.') LoggerRoot.get_base_logger().info('No pending files, skipping upload.')