ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-02-07 13:23:40 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix images reported over history size were not sent if frequency was too high

Browse Source
This commit is contained in:
allegroai 2021-09-20 22:56:44 +03:00
parent 83cd9f1e69
commit 6c96e60174
1 changed files with 11 additions and 6 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

17
clearml/backend_interface/metrics/events.py
View File

@ -12,7 +12,7 @@ from PIL import Image
from six.moves.urllib.parse import urlparse, urlunparse from six.moves.urllib.parse import urlparse, urlunparse
from ...backend_api.services import events from ...backend_api.services import events
from ...config import config, deferred_config from ...config import deferred_config
from ...storage.util import quote_url from ...storage.util import quote_url
from ...utilities.attrs import attrs from ...utilities.attrs import attrs
from ...utilities.process.mp import SingletonLock from ...utilities.process.mp import SingletonLock
@ -288,11 +288,16 @@ class UploadEvent(MetricsEventAdapter):
def get_file_entry(self): def get_file_entry(self):
local_file = None local_file = None
# don't provide file in case this event is out of the history window
last_count = self._get_metric_count(self.metric, self.variant, next=False) # Notice that in case we are running with reporter in subprocess,
if abs(self._count - last_count) > int(self._file_history_size): # when we are here, the cls._metric_counters is actually empty,
output = None # since it was updated on the main process and this function is running from the subprocess.
elif isinstance(self._image_data, (six.StringIO, six.BytesIO)): #
# In the future, if we want to support multi processes reporting images with the same title/series,
# we should move the _count & _filename selection into the subprocess, not the main process.
# For the time being, this will remain a limitation of the Image reporting mechanism.
if isinstance(self._image_data, (six.StringIO, six.BytesIO)):
output = self._image_data output = self._image_data
elif self._image_data is not None: elif self._image_data is not None:
image_data = self._image_data image_data = self._image_data