From 6bba270620b5dd84acb5550b9cb1038704ced0ad Mon Sep 17 00:00:00 2001
From: allegroai <>
Date: Tue, 9 Aug 2022 09:44:25 +0300
Subject: [PATCH] Fix default num of retries when uploading files (should be 3,
 not 1)

---
 clearml/storage/cache.py   | 2 +-
 clearml/storage/helper.py  | 2 +-
 clearml/storage/manager.py | 4 ++--
 3 files changed, 4 insertions(+), 4 deletions(-)

diff --git a/clearml/storage/cache.py b/clearml/storage/cache.py
index 5af8053e..e8c0bbb3 100644
--- a/clearml/storage/cache.py
+++ b/clearml/storage/cache.py
@@ -91,7 +91,7 @@ class CacheManager(object):
             return cached_file
 
         @staticmethod
-        def upload_file(local_file, remote_url, wait_for_upload=True, retries=1):
+        def upload_file(local_file, remote_url, wait_for_upload=True, retries=3):
             # type: (str, str, bool, int) -> Optional[str]
             helper = StorageHelper.get(remote_url)
             result = helper.upload(
diff --git a/clearml/storage/helper.py b/clearml/storage/helper.py
index a3789eed..75b9af66 100644
--- a/clearml/storage/helper.py
+++ b/clearml/storage/helper.py
@@ -604,7 +604,7 @@ class StorageHelper(object):
 
         return dest_path
 
-    def upload(self, src_path, dest_path=None, extra=None, async_enable=False, cb=None, retries=1):
+    def upload(self, src_path, dest_path=None, extra=None, async_enable=False, cb=None, retries=3):
         if not dest_path:
             dest_path = os.path.basename(src_path)
 
diff --git a/clearml/storage/manager.py b/clearml/storage/manager.py
index 441a8835..efcc1192 100644
--- a/clearml/storage/manager.py
+++ b/clearml/storage/manager.py
@@ -54,7 +54,7 @@ class StorageManager(object):
 
     @classmethod
     def upload_file(
-        cls, local_file, remote_url, wait_for_upload=True, retries=1
+        cls, local_file, remote_url, wait_for_upload=True, retries=3
     ):  # type: (str, str, bool, int) -> str
         """
         Upload a local file to a remote location. remote url is the finale destination of the uploaded file.
@@ -70,7 +70,7 @@ class StorageManager(object):
         :param str local_file: Full path of a local file to be uploaded
         :param str remote_url: Full path or remote url to upload to (including file name)
         :param bool wait_for_upload: If False, return immediately and upload in the background. Default True.
-        :param int retries: Number of retries before failing to upload file, default 1.
+        :param int retries: Number of retries before failing to upload file, default 3.
         :return: Newly uploaded remote URL.
         """
         return CacheManager.get_cache_manager().upload_file(