From 2b9a28f90850475bb635b4391614afbf5b017625 Mon Sep 17 00:00:00 2001
From: allegroai <>
Date: Sun, 10 Jan 2021 12:49:44 +0200
Subject: [PATCH] Add warning on archived Task in pipeline (issue #274)

---
 clearml/automation/controller.py | 6 ++++++
 clearml/task.py                  | 1 +
 2 files changed, 7 insertions(+)

diff --git a/clearml/automation/controller.py b/clearml/automation/controller.py
index a3171531..0b4094cb 100644
--- a/clearml/automation/controller.py
+++ b/clearml/automation/controller.py
@@ -8,6 +8,7 @@ from time import time
 from attr import attrib, attrs
 from typing import Sequence, Optional, Mapping, Callable, Any, Union
 
+from ..debugging.log import LoggerRoot
 from ..task import Task
 from ..automation import TrainsJob
 from ..model import BaseModel
@@ -148,12 +149,17 @@ class PipelineController(object):
             if not base_task:
                 raise ValueError('Could not find base_task_project={} base_task_name={}'.format(
                     base_task_project, base_task_name))
+            if Task.archived_tag in base_task.get_system_tags():
+                LoggerRoot.get_base_logger().warning(
+                    'Found base_task_project={} base_task_name={} but it is archived'.format(
+                        base_task_project, base_task_name))
             base_task_id = base_task.id
 
         self._nodes[name] = self.Node(
             name=name, base_task_id=base_task_id, parents=parents or [],
             queue=execution_queue, timeout=time_limit,
             parameters=parameter_override or {})
+
         return True
 
     def start(self, run_remotely=False, step_task_created_callback=None):
diff --git a/clearml/task.py b/clearml/task.py
index 98befb45..a583d821 100644
--- a/clearml/task.py
+++ b/clearml/task.py
@@ -3081,6 +3081,7 @@ class Task(_Task):
         if len(res_tasks) > 1:
             filtered_tasks = [t for t in res_tasks if not getattr(t, system_tags, None) or
                               cls.archived_tag not in getattr(t, system_tags, None)]
+            # if we did not filter everything (otherwise we have only archived tasks, so we return them)
             if filtered_tasks:
                 res_tasks = filtered_tasks