ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-02-01 09:36:49 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix Model.get_weights_package() returns None on error

Browse Source
This commit is contained in:
allegroai 2021-11-30 21:14:18 +02:00
parent 11892a2145
commit 297f33703f
1 changed files with 7 additions and 1 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

8
clearml/model.py
View File

@ -286,7 +286,7 @@ class BaseModel(object):
return self._get_base_model().download_model_weights(raise_on_error=raise_on_error) return self._get_base_model().download_model_weights(raise_on_error=raise_on_error)
def get_weights_package(self, return_path=False, raise_on_error=False): def get_weights_package(self, return_path=False, raise_on_error=False):
# type: (bool, bool) -> Union[str, List[Path]] # type: (bool, bool) -> Optional[Union[str, List[Path]]]
""" """
Download the base model package into a temporary directory (extract the files), or return a list of the Download the base model package into a temporary directory (extract the files), or return a list of the
locally stored filenames. locally stored filenames.
@ -300,6 +300,7 @@ class BaseModel(object):
raise ValueError, otherwise return None on failure and output log warning. raise ValueError, otherwise return None on failure and output log warning.
:return: The model weights, or a list of the locally stored filenames. :return: The model weights, or a list of the locally stored filenames.
if raise_on_error=False, returns None on error.
""" """
# check if model was packaged # check if model was packaged
if not self._is_package(): if not self._is_package():
@ -308,6 +309,11 @@ class BaseModel(object):
# download packaged model # download packaged model
packed_file = self.get_weights(raise_on_error=raise_on_error) packed_file = self.get_weights(raise_on_error=raise_on_error)
if not packed_file:
if raise_on_error:
raise ValueError('Model package \'{}\' could not be downloaded'.format(self.url))
return None
# unpack # unpack
target_folder = mkdtemp(prefix='model_package_') target_folder = mkdtemp(prefix='model_package_')
if not target_folder: if not target_folder: