ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-03-03 18:52:12 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix default argument behavior to match argparse behavior (if value is the same as default, use default value and type)

Browse Source
This commit is contained in:
allegroai 2020-05-13 20:29:35 +03:00
parent 9fc07a39eb
commit 19a24c4b20
1 changed files with 4 additions and 8 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
trains/backend_interface/task/args.py
View File

@ -255,6 +255,10 @@ class _Arguments(object):
try: try:
if current_action.default is None and current_action.type != str and not v: if current_action.default is None and current_action.type != str and not v:
arg_parser_argeuments[k] = v = None arg_parser_argeuments[k] = v = None
elif current_action.default == current_action.type(v):
# this will make sure that if we have type float and default value int,
# we will keep the type as int, just like the original argparser
arg_parser_argeuments[k] = v = current_action.default
else: else:
arg_parser_argeuments[k] = v = current_action.type(v) arg_parser_argeuments[k] = v = current_action.type(v)
except: except:
@ -275,14 +279,6 @@ class _Arguments(object):
current_action.nargs = '?' current_action.nargs = '?'
else: else:
# do not add parameters that do not exist in argparser, they might be the dict # do not add parameters that do not exist in argparser, they might be the dict
# # add new parameters to arg parser
# parent_parser.add_argument(
# '--%s' % k,
# default=v,
# type=type(v),
# required=False,
# help='Task parameter %s (default %s)' % (k, v),
# )
pass pass
except ArgumentError: except ArgumentError:
pass pass