From 11443e20f859fa637f87f688eaa6a17844a992f4 Mon Sep 17 00:00:00 2001 From: allegroai <> Date: Fri, 22 May 2020 11:01:54 +0300 Subject: [PATCH] Fix report histogram xlabels without labels will add "trace 0" in legend instead of series name --- trains/logger.py | 10 +++------- trains/utilities/plotly_reporter.py | 2 ++ 2 files changed, 5 insertions(+), 7 deletions(-) diff --git a/trains/logger.py b/trains/logger.py index 959bd771..b835dde6 100644 --- a/trains/logger.py +++ b/trains/logger.py @@ -86,8 +86,6 @@ class Logger(object): logger = Logger.current_logger() :return: The Logger object (a singleton) for the current running Task. - - :rtype: Logger object """ from .task import Task task = Task.current_task() @@ -200,7 +198,9 @@ class Logger(object): mode=None # type: Optional[str] ): """ - For explicit reporting, plot a (default stacked) histogram. + For explicit reporting, plot a (default grouped) histogram. + Notice this function will not calculate the histogram, + it assumes the histogram was already calculated in `values` For example: @@ -899,8 +899,6 @@ class Logger(object): :return: The default upload destination URI. For example, ``s3://bucket/directory/`` or ``file:///tmp/debug/``. - - :rtype: str """ return self._default_upload_destination or self._task._get_default_report_storage_uri() @@ -927,8 +925,6 @@ class Logger(object): Get the Logger flush period. :return: The logger flush period in seconds. - - :rtype: int """ if self._flusher: return self._flusher.period diff --git a/trains/utilities/plotly_reporter.py b/trains/utilities/plotly_reporter.py index f1364e27..bf30d659 100644 --- a/trains/utilities/plotly_reporter.py +++ b/trains/utilities/plotly_reporter.py @@ -36,6 +36,8 @@ def create_2d_histogram_plot(np_row_wise, labels, title=None, xtitle=None, ytitl if len(labels) == 1: labels = [labels] * np_row_wise.shape[0] assert len(xlabels) == np_row_wise.shape[1] + elif not labels and xlabels: + labels = [series] data = [_np_row_to_plotly_data_item(np_row=np_row_wise[i, :], label=labels[i] if labels else None, xlabels=xlabels) for i in range(np_row_wise.shape[0])]