ClearML/clearml
1
0
Fork 0
mirror of https://github.com/clearml/clearml synced 2025-02-07 21:33:25 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix argparse nargs passed in command line --nargs 1 2 should be stored as '[1, 2]' not as "['1', '2']"

Browse Source
This commit is contained in:
allegroai 2021-01-24 09:14:27 +02:00
parent 6b8f21b30e
commit 0962e53f0b
2 changed files with 7 additions and 4 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

6
clearml/backend_interface/task/args.py
View File

@ -95,7 +95,7 @@ class _Arguments(object):
else: else:
args_dict = call_original_argparser(a_parser, args=a_args, namespace=a_namespace).__dict__ args_dict = call_original_argparser(a_parser, args=a_args, namespace=a_namespace).__dict__
defaults_ = { defaults_ = {
a.dest: cls.__cast_arg(args_dict.get(a.dest)) for a in actions a.dest: cls.__cast_arg(args_dict.get(a.dest), a.type) for a in actions
} }
except Exception: except Exception:
# don't crash us if we failed parsing the inputs # don't crash us if we failed parsing the inputs
@ -539,10 +539,12 @@ class _Arguments(object):
return dictionary return dictionary
@classmethod @classmethod
def __cast_arg(cls, arg): def __cast_arg(cls, arg, dtype=None):
if arg is None or callable(arg): if arg is None or callable(arg):
return '' return ''
# If this an instance, just store the type # If this an instance, just store the type
if str(hex(id(arg))) in str(arg): if str(hex(id(arg))) in str(arg):
return str(type(arg)) return str(type(arg))
if dtype in (float, int) and isinstance(arg, list):
return [dtype(a) for a in arg]
return arg return arg

5
clearml/utilities/args.py
View File

@ -150,10 +150,11 @@ class PatchArgumentParser:
if parsed_args_namespace and isinstance(parsed_args_namespace, Namespace): if parsed_args_namespace and isinstance(parsed_args_namespace, Namespace):
for k, v in parser._parsed_arg_string_lookup.items(): # noqa for k, v in parser._parsed_arg_string_lookup.items(): # noqa
if hasattr(parsed_args_namespace, k): if hasattr(parsed_args_namespace, k):
if isinstance(getattr(parsed_args_namespace, k, None), list) and not isinstance(v, list):
v = [v]
setattr( setattr(
parsed_args_namespace, k, parsed_args_namespace, k,
str([v] if (isinstance(getattr(parsed_args_namespace, k, None), list) and v if isinstance(v, list) else str(v)
not isinstance(v, list)) else v)
) )
PatchArgumentParser._last_parsed_args = (PatchArgumentParser._last_parsed_args or []) + [parsed_args] PatchArgumentParser._last_parsed_args = (PatchArgumentParser._last_parsed_args or []) + [parsed_args]