From babcb8c9cf2a2130ae8d2c6e9132ee0b8e2e0af4 Mon Sep 17 00:00:00 2001 From: Shubham Takode Date: Wed, 6 Mar 2024 17:16:16 +0530 Subject: [PATCH] moved component to different folder --- .../pipeline-step-info.component.html | 4 ++-- .../pipeline-step-info.component.scss | 12 ------------ .../pipeline-step-info.component.ts | 4 ++-- ...eline-step-parameters-edit-dialog.component.html} | 0 ...eline-step-parameters-edit-dialog.component.scss} | 0 ...ne-step-parameters-edit-dialog.component.spec.ts} | 2 +- ...ipeline-step-parameters-edit-dialog.component.ts} | 10 +++++----- src/app/webapp-common/pipelines/pipelines.module.ts | 4 ++-- 8 files changed, 12 insertions(+), 24 deletions(-) rename src/app/webapp-common/pipelines/{pipeline-parameters-dialog/pipeline-parameters-dialog.component.html => edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.html} (100%) rename src/app/webapp-common/pipelines/{pipeline-parameters-dialog/pipeline-parameters-dialog.component.scss => edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.scss} (100%) rename src/app/webapp-common/pipelines/{pipeline-parameters-dialog/pipeline-parameters-dialog.component.spec.ts => edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.spec.ts} (85%) rename src/app/webapp-common/pipelines/{pipeline-parameters-dialog/pipeline-parameters-dialog.component.ts => edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.ts} (68%) diff --git a/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.html b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.html index dd3c5865..72c0de20 100644 --- a/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.html +++ b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.html @@ -57,10 +57,10 @@ -
show more -
+
METRICS
diff --git a/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.scss b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.scss index 53e4e5a1..c0334971 100644 --- a/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.scss +++ b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.scss @@ -174,17 +174,5 @@ } } } - .show-more-text { - color: $blue-300; - text-decoration: underline; - cursor: pointer; - margin-top: 12px; - margin-bottom: 12px; - margin-left: auto; - float: inline-end; - } - .show-more-text:hover { - color: $blue-100; - } } diff --git a/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.ts b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.ts index 458fe001..05c175e1 100644 --- a/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.ts +++ b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-info/pipeline-step-info.component.ts @@ -17,7 +17,7 @@ import { trackByValue } from "@common/shared/utils/forms-track-by"; import { cloneDeep } from "lodash-es"; import { ConfirmDialogComponent } from "@common/shared/ui-components/overlay/confirm-dialog/confirm-dialog.component"; import { MatDialog } from "@angular/material/dialog"; -import { PipelineParametersDialogComponent } from "@common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component"; +import { PipelineStepParametersEditDialogComponent } from "@common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component"; @Component({ selector: "sm-pipeline-step-info", @@ -126,7 +126,7 @@ export class PipelineStepInfoComponent { }, 3000) */ } public showMoreClicked(parameters: any[]) { - this.matDialog.open(PipelineParametersDialogComponent, { + this.matDialog.open(PipelineStepParametersEditDialogComponent, { data: { parameters: parameters, paramsChanged: this.paramsChanged.bind(this), diff --git a/src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.html b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.html similarity index 100% rename from src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.html rename to src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.html diff --git a/src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.scss b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.scss similarity index 100% rename from src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.scss rename to src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.scss diff --git a/src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.spec.ts b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.spec.ts similarity index 85% rename from src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.spec.ts rename to src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.spec.ts index ff4d25d8..4e5704a0 100644 --- a/src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.spec.ts +++ b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.spec.ts @@ -1,6 +1,6 @@ import { ComponentFixture, TestBed } from '@angular/core/testing'; -import { PipelineParametersDialogComponent } from './pipeline-parameters-dialog.component'; +import { PipelineParametersDialogComponent } from './pipeline-step-parameters-edit-dialog.component'; describe('PipelineParametersDialogComponent', () => { let component: PipelineParametersDialogComponent; diff --git a/src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.ts b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.ts similarity index 68% rename from src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.ts rename to src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.ts index d8a41acf..1f6723ed 100644 --- a/src/app/webapp-common/pipelines/pipeline-parameters-dialog/pipeline-parameters-dialog.component.ts +++ b/src/app/webapp-common/pipelines/edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component.ts @@ -2,11 +2,11 @@ import { Component, Inject } from "@angular/core"; import { MAT_DIALOG_DATA, MatDialogRef } from "@angular/material/dialog"; @Component({ - selector: "sm-pipeline-parameters-dialog", - templateUrl: "./pipeline-parameters-dialog.component.html", - styleUrls: ["./pipeline-parameters-dialog.component.scss"], + selector: "sm-pipeline-step-parameters-edit-dialog", + templateUrl: "./pipeline-step-parameters-edit-dialog.component.html", + styleUrls: ["./pipeline-step-parameters-edit-dialog.component.scss"], }) -export class PipelineParametersDialogComponent { +export class PipelineStepParametersEditDialogComponent { parameters: any[]; paramsChanged: () => void; setIsAutoCompleteOpen: (focus: boolean) => void; @@ -16,7 +16,7 @@ export class PipelineParametersDialogComponent { trackByValue: any; constructor( - private matDialogRef: MatDialogRef, + private matDialogRef: MatDialogRef, @Inject(MAT_DIALOG_DATA) public data: any ) { this.parameters = data.parameters; diff --git a/src/app/webapp-common/pipelines/pipelines.module.ts b/src/app/webapp-common/pipelines/pipelines.module.ts index 0d0d7c6e..c570a29e 100644 --- a/src/app/webapp-common/pipelines/pipelines.module.ts +++ b/src/app/webapp-common/pipelines/pipelines.module.ts @@ -75,7 +75,7 @@ import { FilterPipe } from "@common/shared/pipes/filter.pipe"; import { FileSizePipe } from "@common/shared/pipes/filesize.pipe"; import { RegexPipe } from "@common/shared/pipes/filter-regex.pipe"; import { FilterMonitorMetricPipe } from "@common/shared/pipes/filter-monitor-metric.pipe"; -import { PipelineParametersDialogComponent } from "./pipeline-parameters-dialog/pipeline-parameters-dialog.component"; +import { PipelineStepParametersEditDialogComponent } from "./edit-pipeline-page/pipeline-step-parameters-edit-dialog/pipeline-step-parameters-edit-dialog.component"; import { PipelineDetailsDrawerComponent } from './details-dialog/pipeline-details-drawer.component'; export const pipelinesSyncedKeys = ["projects.showPipelineExamples"]; @@ -137,7 +137,7 @@ const getInitState = (userPreferences: UserPreferences) => ({ PipelineSettingDialogComponent, PipelineSettingFormComponent, PipelineStepInfoComponent, - PipelineParametersDialogComponent, + PipelineStepParametersEditDialogComponent, PipelineDetailsDrawerComponent, ], imports: [