From e7c9daa42b50ed650d72c0ff2c2e1da0631bceac Mon Sep 17 00:00:00 2001 From: allegroai <> Date: Tue, 28 Mar 2023 16:45:44 +0300 Subject: [PATCH] Fix get_task_events to correctly use last_iters for model events --- apiserver/bll/event/event_bll.py | 3 +-- apiserver/services/events.py | 3 --- 2 files changed, 1 insertion(+), 5 deletions(-) diff --git a/apiserver/bll/event/event_bll.py b/apiserver/bll/event/event_bll.py index 8649016..2f1ebaa 100644 --- a/apiserver/bll/event/event_bll.py +++ b/apiserver/bll/event/event_bll.py @@ -714,7 +714,6 @@ class EventBLL(object): size=500, scroll_id=None, no_scroll=False, - model_events=False, ) -> TaskEventsResult: if scroll_id == self.empty_scroll: return TaskEventsResult() @@ -743,7 +742,7 @@ class EventBLL(object): if metrics: must.append(get_metric_variants_condition(metrics)) - if last_iter_count is None or model_events: + if last_iter_count is None: must.append({"terms": {"task": task_ids}}) else: tasks_iters = self.get_last_iters( diff --git a/apiserver/services/events.py b/apiserver/services/events.py index 3ca807b..7ce64bf 100644 --- a/apiserver/services/events.py +++ b/apiserver/services/events.py @@ -410,7 +410,6 @@ def get_scalar_metric_data(call, company_id, _): metrics={metric: []}, scroll_id=scroll_id, no_scroll=no_scroll, - model_events=model_events, ) call.result.data = dict( @@ -576,7 +575,6 @@ def _get_multitask_plots( sort=[{"iter": {"order": "desc"}}], scroll_id=scroll_id, no_scroll=no_scroll, - model_events=model_events, ) return_events = _get_top_iter_unique_events_per_task( result.events, max_iters=last_iters, task_names=task_names @@ -786,7 +784,6 @@ def get_debug_images_v1_8(call, company_id, _): sort=[{"iter": {"order": "desc"}}], last_iter_count=iters, scroll_id=scroll_id, - model_events=model_events, ) return_events = result.events