ClearML/clearml-server
1
0
Fork 0
mirror of https://github.com/clearml/clearml-server synced 2025-01-31 10:56:48 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Fix tasks.started to correctly handle null values in the started field

Browse Source
This commit is contained in:
allegroai 2024-02-13 16:17:02 +02:00
parent 6e484ea8f4
commit 801e536c5e
1 changed files with 10 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
apiserver/services/tasks.py
View File

@ -266,7 +266,7 @@ def get_by_id_ex(call: APICall, company_id, _):
call.result.data = {"tasks": tasks} call.result.data = {"tasks": tasks}
@endpoint("tasks.get_all", required_fields=[]) @endpoint("tasks.get_all")
def get_all(call: APICall, company_id, _): def get_all(call: APICall, company_id, _):
conform_tag_fields(call, call.data) conform_tag_fields(call, call.data)
call_data = escape_execution_parameters(call.data) call_data = escape_execution_parameters(call.data)
@ -364,13 +364,21 @@ def stopped(call: APICall, company_id, req_model: UpdateRequest):
response_data_model=StartedResponse, response_data_model=StartedResponse,
) )
def started(call: APICall, company_id, req_model: UpdateRequest): def started(call: APICall, company_id, req_model: UpdateRequest):
started_update = {}
if Task.objects(id=req_model.task, started=None).only("id"):
# this is the fix for older versions putting started to None on reset
started_update["started"] = datetime.utcnow()
else:
# don't override a previous, smaller "started" field value
started_update["min__started"] = datetime.utcnow()
res = StartedResponse( res = StartedResponse(
**set_task_status_from_call( **set_task_status_from_call(
req_model, req_model,
company_id=company_id, company_id=company_id,
identity=call.identity, identity=call.identity,
new_status=TaskStatus.in_progress, new_status=TaskStatus.in_progress,
min__started=datetime.utcnow(), # don't override a previous, smaller "started" field value **started_update,
) )
) )
res.started = res.updated res.started = res.updated