ClearML/clearml-server
1
0
Fork 0
mirror of https://github.com/clearml/clearml-server synced 2025-03-04 02:59:05 +00:00
Code Issues Actions Packages Projects Releases Wiki Activity

Allow updating comments on published reports

Browse Source
This commit is contained in:
allegroai 2023-01-24 14:40:32 +02:00
parent a45d47f5d7
commit 15db9cdaef
2 changed files with 6 additions and 3 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

2
apiserver/services/reports.py
View File

@ -80,7 +80,7 @@ def update_report(call: APICall, company_id: str, request: UpdateReportRequest):
if not partial_update_dict: if not partial_update_dict:
return UpdateResponse(updated=0) return UpdateResponse(updated=0)
allowed_for_published = set(partial_update_dict.keys()).issubset({"tags", "name"}) allowed_for_published = set(partial_update_dict.keys()).issubset({"tags", "name", "comment"})
if task.status != TaskStatus.created and not allowed_for_published: if task.status != TaskStatus.created and not allowed_for_published:
raise errors.bad_request.InvalidTaskStatus( raise errors.bad_request.InvalidTaskStatus(
expected=TaskStatus.created, status=task.status expected=TaskStatus.created, status=task.status

7
apiserver/tests/automated/test_reports.py
View File

@ -56,13 +56,16 @@ class TestReports(TestService):
self.assertEqual(ret.tags, []) self.assertEqual(ret.tags, [])
self.api.reports.publish(task=task_id) self.api.reports.publish(task=task_id)
with self.api.raises(errors.bad_request.InvalidTaskStatus): with self.api.raises(errors.bad_request.InvalidTaskStatus):
self.api.reports.update(task=task_id, comment=comment) self.api.reports.update(task=task_id, report="New report text")
# update on tags or rename can be done for published report too # update on tags or rename can be done for published report too
self.api.reports.update(task=task_id, name="new name", tags=["test"]) self.api.reports.update(
task=task_id, name="new name", tags=["test"], comment="Yet another comment"
)
task = self.api.tasks.get_all_ex(id=[task_id]).tasks[0] task = self.api.tasks.get_all_ex(id=[task_id]).tasks[0]
self.assertEqual(task.tags, ["test"]) self.assertEqual(task.tags, ["test"])
self.assertEqual(task.name, "new name") self.assertEqual(task.name, "new name")
self.assertEqual(task.comment, "Yet another comment")
# move under another project autodeletes the empty project # move under another project autodeletes the empty project
new_project_name = "Reports Test" new_project_name = "Reports Test"