From e89a24bd5e8f81285667e6b239e18eaae9d49bb4 Mon Sep 17 00:00:00 2001
From: Valeriano Manassero
 <14011549+valeriano-manassero@users.noreply.github.com>
Date: Thu, 16 Mar 2023 11:30:34 +0100
Subject: [PATCH] Changed: improved ingresses

---
 charts/clearml-serving/values.yaml | 32 +++++++++++++++++++-----------
 1 file changed, 20 insertions(+), 12 deletions(-)

diff --git a/charts/clearml-serving/values.yaml b/charts/clearml-serving/values.yaml
index c207aeb..67e5a69 100644
--- a/charts/clearml-serving/values.yaml
+++ b/charts/clearml-serving/values.yaml
@@ -54,10 +54,17 @@ clearml_serving_inference:
     targetMemory: 50
   # -- Ingress exposing configurations
   ingress:
+    # -- Enable/Disable ingress
     enabled: false
+    # -- ClassName (must be defined if no default ingressClassName is available)
+    ingressClassName: ""
+    # -- Ingress hostname domain
     hostName: "serving.clearml.127-0-0-1.nip.io"
+    # -- Reference to secret containing TLS certificate. If set, it enables HTTPS on ingress rule.
     tlsSecretName: ""
+    # -- Ingress annotations
     annotations: {}
+    # -- Ingress root path url
     path: "/"
 
 # -- ClearML serving Triton configurations
@@ -89,22 +96,17 @@ clearml_serving_triton:
     targetMemory: 50
   # -- Ingress exposing configurations
   ingress:
+    # -- Enable/Disable ingress
     enabled: false
+    # -- ClassName (must be defined if no default ingressClassName is available)
+    ingressClassName: ""
+    # -- Ingress hostname domain
     hostName: "serving-grpc.clearml.127-0-0-1.nip.io"
+    # -- Reference to secret containing TLS certificate. If set, it enables HTTPS on ingress rule.
     tlsSecretName: ""
+    # -- Ingress annotations
     annotations: {}
-    #  # Example for AWS ALB
-    #  kubernetes.io/ingress.class: alb
-    #  alb.ingress.kubernetes.io/backend-protocol: HTTP
-    #  alb.ingress.kubernetes.io/backend-protocol-version: GRPC
-    #  alb.ingress.kubernetes.io/certificate-arn: <cerntificate arn>
-    #  alb.ingress.kubernetes.io/ssl-redirect: '443'
-    #  alb.ingress.kubernetes.io/listen-ports: '[{"HTTPS":443}]'
-    #  alb.ingress.kubernetes.io/target-type: ip
-    #
-    #  # Example for NNGINX ingress controller
-    #  nginx.ingress.kubernetes.io/ssl-redirect: "true"
-    #  nginx.ingress.kubernetes.io/backend-protocol: "GRPC"
+    # -- Ingress root path url
     path: "/"
 
 # -- Configuration from https://github.com/bitnami/charts/blob/main/bitnami/kafka/values.yaml
@@ -114,6 +116,12 @@ kafka:
 # -- Configuration from https://github.com/prometheus-community/helm-charts/blob/main/charts/prometheus/values.yaml
 prometheus:
   enabled: true
+  kube-state-metrics:
+    enabled: false
+  prometheus-node-exporter:
+    enabled: false
+  prometheus-pushgateway:
+    enabled: false
 
 # -- Configuration from https://github.com/grafana/helm-charts/blob/main/charts/grafana/values.yaml
 grafana: