From 03223fc1c13b676c4d6b627685704fe715777e01 Mon Sep 17 00:00:00 2001
From: Valeriano Manassero
 <14011549+valeriano-manassero@users.noreply.github.com>
Date: Tue, 17 Aug 2021 14:59:13 +0200
Subject: [PATCH] Use Recreate as strategy (#19)

* use Recreate as strategybump up version

* fix strategy indentation and position

* updatesStrategy configurable

* updateStrategy parameter

* use 2.2.0 instead of patch release
---
 charts/clearml/Chart.yaml                      | 2 +-
 charts/clearml/README.md                       | 4 +++-
 charts/clearml/templates/deployment-agent.yaml | 2 ++
 charts/clearml/values.yaml                     | 2 ++
 4 files changed, 8 insertions(+), 2 deletions(-)

diff --git a/charts/clearml/Chart.yaml b/charts/clearml/Chart.yaml
index 25dec76..aa68b62 100644
--- a/charts/clearml/Chart.yaml
+++ b/charts/clearml/Chart.yaml
@@ -2,7 +2,7 @@ apiVersion: v2
 name: clearml
 description: MLOps platform
 type: application
-version: "2.1.1"
+version: "2.2.0"
 appVersion: "1.1.1"
 home: https://clear.ml
 icon: https://raw.githubusercontent.com/allegroai/clearml/master/docs/clearml-logo.svg
diff --git a/charts/clearml/README.md b/charts/clearml/README.md
index 1e78f93..33c21db 100644
--- a/charts/clearml/README.md
+++ b/charts/clearml/README.md
@@ -1,6 +1,6 @@
 # ClearML Ecosystem for Kubernetes
 
-![Version: 2.1.1](https://img.shields.io/badge/Version-2.1.1-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.1.1](https://img.shields.io/badge/AppVersion-1.1.1-informational?style=flat-square)
+![Version: 2.2.0](https://img.shields.io/badge/Version-2.2.0-informational?style=flat-square) ![Type: application](https://img.shields.io/badge/Type-application-informational?style=flat-square) ![AppVersion: 1.1.1](https://img.shields.io/badge/AppVersion-1.1.1-informational?style=flat-square)
 
 MLOps platform
 
@@ -131,6 +131,7 @@ For detailed instructions, see the [Optional Configuration](https://github.com/a
 | agentGroups.agent-group-cpu.queues | string | `"default"` |  |
 | agentGroups.agent-group-cpu.replicaCount | int | `1` |  |
 | agentGroups.agent-group-cpu.tolerations | list | `[]` |  |
+| agentGroups.agent-group-cpu.updateStrategy | string | `"Recreate"` |  |
 | agentGroups.agent-group-gpu.affinity | object | `{}` |  |
 | agentGroups.agent-group-gpu.agentVersion | string | `""` |  |
 | agentGroups.agent-group-gpu.awsAccessKeyId | string | `nil` |  |
@@ -153,6 +154,7 @@ For detailed instructions, see the [Optional Configuration](https://github.com/a
 | agentGroups.agent-group-gpu.queues | string | `"default"` |  |
 | agentGroups.agent-group-gpu.replicaCount | int | `0` |  |
 | agentGroups.agent-group-gpu.tolerations | list | `[]` |  |
+| agentGroups.agent-group-gpu.updateStrategy | string | `"Recreate"` |  |
 | agentservices.affinity | object | `{}` |  |
 | agentservices.agentVersion | string | `""` |  |
 | agentservices.awsAccessKeyId | string | `nil` |  |
diff --git a/charts/clearml/templates/deployment-agent.yaml b/charts/clearml/templates/deployment-agent.yaml
index 080e15d..b2dc78a 100644
--- a/charts/clearml/templates/deployment-agent.yaml
+++ b/charts/clearml/templates/deployment-agent.yaml
@@ -9,6 +9,8 @@ metadata:
     {{- include "clearml.labels" $ | nindent 4 }}
 spec:
   replicas: {{ .replicaCount }}
+  strategy:
+    type: {{ .updateStrategy }}
   selector:
     matchLabels:
       {{- include "clearml.selectorLabelsAgent" $ | nindent 6 }}
diff --git a/charts/clearml/values.yaml b/charts/clearml/values.yaml
index 779cbcc..e7e6068 100644
--- a/charts/clearml/values.yaml
+++ b/charts/clearml/values.yaml
@@ -186,6 +186,7 @@ agentGroups:
   agent-group-cpu:
     name: agent-group-cpu
     replicaCount: 1
+    updateStrategy: Recreate
     nvidiaGpusPerAgent: 0
     agentVersion: ""  # if set, it *MUST* include comparison operator (e.g. ">=0.16.1")
     queues: "default"  # multiple queues can be specified separated by a space (e.g. "important_jobs default")
@@ -218,6 +219,7 @@ agentGroups:
   agent-group-gpu:
     name: agent-group-gpu
     replicaCount: 0
+    updateStrategy: Recreate
     nvidiaGpusPerAgent: 1
     agentVersion: ""  # if set, it *MUST* include comparison operator (e.g. ">=0.16.1")
     queues: "default"  # multiple queues can be specified separated by a space (e.g. "important_jobs default")